Repository navigation
Feat/215 persist report filters - #229
Merged
shossain786 merged 3 commits intoNov 1, 2026
Merged
shossain786 merged 3 commits into
shossain786 merged 3 commits into
Conversation
shossain786
requested changes
Nov 1, 2026
shossain786
left a comment
Contributor
There was a problem hiding this comment.
Thanks @PUSHPAK-JAISWAL — the persistence logic itself looks good: guarded storage access, stale tags ignored, and no tab switching on load. A few small things to trim before merge:
pom.xml: drop the explicitjackson-coredependency.jackson-databindalready brings it in transitively, and the checklist says no new dependencies without discussion.- Drop the unused
JsonProcessingExceptionimports inHtmlReportGeneratorTestandReportTabBehaviourTest. - Drop the
JSON.parse('{{DONUT_DATA}}')/{{TREND_DATA}}change (and the'escaping plus the matching test edit). It's unrelated to #215, and escaping only'would break on a backslash in the data. Separate PR if you still want it. - Optional: please confirm manually that a filter survives a reload.
Once 1–3 are out I'm happy to merge.
Contributor
Author
|
@shossain786 ok i will make changes |
PUSHPAK-JAISWAL
force-pushed
the
feat/215-persist-report-filters
branch
from
November 1, 2026 06:59
cf0ead7 to
c293899
Compare
Contributor
Author
|
@shossain786 i have changed the requested and did a manual refresh verification this is the output if i am able to attach it. Screen.Recording.2026-11-01.122900.mp4 |
shossain786
approved these changes
Nov 1, 2026
shossain786
left a comment
Contributor
There was a problem hiding this comment.
Thanks @PUSHPAK-JAISWAL — all three items are addressed and the PR is now scoped to #215. Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The Test Cases tab in the HTML report previously reset to "All" every time the report was reopened or refreshed, and active tag filters were cleared, while theme preference already persisted via
sb-themeinlocalStorage.This PR persists the active status filter and tag filter across page reloads using
localStorage, following the same pattern assb-theme:sb-status-filter): Persists the selected status (PASSED,FAILED,SKIPPED,FLAKY) tolocalStorage; removes the key when "ALL" is selected.sb-tag-filter): Persists the active tag name tolocalStorage; removes the key when the active tag is toggled off or cleared withclearTagFilter().applySearch().localStorageread, write, and remove operations are enclosed intry ... catchblocks to gracefully handle Safari private browsing mode, disabled storage, or quota limits without failing report rendering.{{DONUT_DATA}}and{{TREND_DATA}}inreport.jswithJSON.parse('...')to eliminate JavaScript parser/linter errors (ts(1136)).com.fasterxml.jackson.core:jackson-coreinpom.xmlto ensure clean IDE/language server type resolution forJsonProcessingException.Closes #215
Type of change
Checklist
mvn clean test/mvn clean verify)@SeleniumBootApipublic APIs (or a major version bump is justified below)CHANGELOG.md)