Repository navigation
Docs/why accessibility and waitengine - #222
Merged
shossain786 merged 8 commits intoOct 30, 2026
Merged
shossain786 merged 8 commits into
shossain786 merged 8 commits into
Conversation
…nium-boot Co-authored-by: Yuvaraj Deshmukh <yuvid163@gmail.com>
…docs Co-authored-by: Yuvaraj Deshmukh <yuvid163@gmail.com>
Co-authored-by: Yuvaraj Deshmukh <yuvid163@gmail.com>
PUSHPAK-JAISWAL
force-pushed
the
docs/why-accessibility-and-waitengine
branch
from
October 28, 2026 10:32
8efcf24 to
eb48d3b
Compare
shossain786
requested changes
Oct 29, 2026
shossain786
left a comment
Contributor
There was a problem hiding this comment.
Thanks Pushpak, nice pages. I checked the API names against the code and they exist. Two fixes:
- The description lists
WhyDocSnippetsCompileTest.java, but it isn't in the PR. Please add it or update the description. - A few claims are absolute: "Survives CSS refactoring: Yes", "Network-Aware: Yes". Please soften them, and confirm the sprint-3
<input type="submit">example actually matchesRole.BUTTONin the role-matching code.
Contributor
Author
|
@shossain786 on it |
Co-authored-by: Pushpak Jaiswal <149317014+PUSHPAK-JAISWAL@users.noreply.github.com>
Co-authored-by: Pushpak Jaiswal <149317014+PUSHPAK-JAISWAL@users.noreply.github.com>
Contributor
Author
|
@shossain786 the requested changes are done as requested. Please review those and if there are any more changes please reply. |
shossain786
approved these changes
Oct 30, 2026
shossain786
left a comment
Contributor
There was a problem hiding this comment.
Thanks Pushpak — claims softened and the submit-button matching checks out against Role.java. I removed the stale WhyDocSnippetsCompileTest line from the description (that file isn't in the PR). Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Closes #128
Adds two new documentation pages to
docs-site/docs/why/matching the voice, philosophy, and structure of the existing pages:Why accessibility-first locators? (
why-accessibility-first-locators.md):getByRole,getByLabel, andgetByTexttarget the accessibility tree (roles and accessible names) to survive markup changes.role="button"-> input submit) where accessibility locators keep passing while CSS/XPath fail.By(toBy()) and nativeWebDriver.Why WaitEngine? (
why-wait-engine.md):WebDriverWaitinstances with arbitrary hardcoded timeouts and flakyThread.sleephacks.selenium-boot.yml(timeouts.explicit).waitForVisible,waitForInvisible,waitForClickable,waitForText,waitForUrlMatches,waitForPageLoad,waitForNetworkIdle).ExpectedCondition<T>escape hatches viaWaitEngine.wait(...).Additional changes:
docs-site/sidebars.jsunder theWhy Selenium Bootcategory.why-selenium-boot.md,why-not-plain-selenium.md, andwhy-not-playwright.md.Type of change
Checklist
mvn clean verify)@SeleniumBootApipublic APIs (or a major version bump is justified below)docs-site/)Notes for reviewers
npm run buildcompleted with zero broken links or markdown syntax errors).