docs: scrub stale discover-peers references (PLT-452 follow-up)#401
Conversation
PR-C's cross-review (sei-network + kubernetes lenses) flagged docs/comments that still present the retired discover-peers task as part of the current bootstrap flow. Peering is controller-owned via the config-apply persistent_peers override; there is no discover-peers task. Fixed (misstate current behavior): - internal/task/bootstrap_resources.go: bootstrapWaitCommand doc comment no longer lists discover-peers in the bootstrap-task set it waits on. - README.md: Full node "Key tasks" chain drops discover-peers. - docs/design-seinode-import-volume.md: the "runs exactly as today" task list drops discover-peers. - docs/design/composable-genesis.md: both per-node init-plan flows drop the discover-peers step. - .agent/runbooks/migrating-validator-to-byo-secrets.md: the bootstrap-plan chain + its explanation now credit config-apply (via the resolved-peer override) with writing persistent-peers, not discover-peers. Deliberately left: - docs/known-issues-node-alarms.md: a dated incident record — it accurately describes a failure that occurred when discover-peers existed; rewriting it would falsify history. - Three Go test-comment analogies (common_overrides_test.go, controller_test.go) and the intentional TestCEL_DiscoverPeers_Removed_Rejected guard — internal references that don't misstate current behavior. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
PR SummaryLow Risk Overview Docs drop Code comments only:
Reviewed by Cursor Bugbot for commit 3285275. Bugbot is set up for automated code reviews on this repo. Configure here. |
…ngling analogy) PR-401 cross-review (sei-network) optional hardenings: - docs/known-issues-node-alarms.md: annotate the discover-peers mention as historical so a future reader grepping discover-peers isn't misled — keeps the incident record intact, adds the controller-owned-peering context. - controller_test.go: drop the trailing "Mirrors the DiscoverPeers poll shape" analogy — the first sentence already states the poll-to-completion shape, and the analogy referenced now-deleted code. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
What
Follow-up to PR-C (#400). PR-C's Coral cross-review (sei-network + kubernetes lenses) flagged docs and one code comment that still present the retired discover-peers task as part of the current bootstrap flow. Peering is wholly controller-owned via the config-apply
persistent_peersoverride — there is no discover-peers task anywhere in the stack.This PR scrubs the references that misstate current behavior:
internal/task/bootstrap_resources.gobootstrapWaitCommanddoc comment no longer listsdiscover-peersin the bootstrap-task set it waits on (the sei-network finding)README.mddiscover-peersdocs/design-seinode-import-volume.mddiscover-peersdocs/design/composable-genesis.mddiscover-peersstep.agent/runbooks/migrating-validator-to-byo-secrets.mdconfig-apply(via the controller-resolved peer override) with writingpersistent-peers, notdiscover-peersDeliberately left (with rationale)
docs/known-issues-node-alarms.md— a dated incident record. It accurately describes a failure that occurred atdiscover-peerswhen that task existed; rewriting it would falsify the historical record.common_overrides_test.go:44,controller_test.go:705) and the intentionalTestCEL_DiscoverPeers_Removed_Rejectedregression guard — internal references that don't misstate current product behavior.Risk
Docs + one non-functional code comment. No logic change;
go build ./...clean.🤖 Generated with Claude Code