Remove unused parquet and duckdb receipt store#3580
Conversation
Remove the experimental / unused parquet and duckdb receipt store. Remove redundant tests and adjust benchmarking.
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3580 +/- ##
==========================================
- Coverage 59.22% 58.35% -0.87%
==========================================
Files 2214 2140 -74
Lines 183389 174791 -8598
==========================================
- Hits 108604 101999 -6605
+ Misses 64994 63701 -1293
+ Partials 9791 9091 -700
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
PR SummaryMedium Risk Overview The Docker/Makefile parquet cluster targets ( Dependencies drop Reviewed by Cursor Bugbot for commit ed3e474. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0fca0ae6f9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -142,13 +141,12 @@ func NewRecieptStoreSimulator( | |||
| Backend: "parquet", | |||
There was a problem hiding this comment.
Use a supported receipt backend in cryptosim
When the cryptosim receipt simulator is created, this hard-coded Backend: "parquet" now goes through receipt.NewReceiptStoreWithReadMetrics, but this commit removed the parquet implementation and newReceiptBackend only accepts the pebble backend. As a result any cryptosim run that enables receipt generation/reads fails during simulator initialization with unsupported receipt store backend: parquet, so the receipt benchmark can no longer start.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ed3e474. Configure here.
| "os" | ||
| "path/filepath" | ||
| "sync" | ||
| "time" |
There was a problem hiding this comment.
Unused tx hash index code
Low Severity
The parquet receipt store and its tx-hash index wiring are removed, yet PebbleTxHashIndex and related APIs in tx_hash_index.go have no callers outside their tests. That unused surface suggests the parquet-specific index path was not fully removed with the backend.
Reviewed by Cursor Bugbot for commit ed3e474. Configure here.
cody-littley
left a comment
There was a problem hiding this comment.
LGTM. Please get signoff with @Kbhat1 before merging, as he's currently in charge of managing all recieptDB stuff.


Remove the experimental / unused parquet and duckdb receipt store. Remove redundant tests and adjust benchmarking.