Skip to content

Remove unused parquet and duckdb receipt store#3580

Open
masih wants to merge 4 commits into
mainfrom
masih/rm-duckdb-pebble-dependency
Open

Remove unused parquet and duckdb receipt store#3580
masih wants to merge 4 commits into
mainfrom
masih/rm-duckdb-pebble-dependency

Conversation

@masih

@masih masih commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Remove the experimental / unused parquet and duckdb receipt store. Remove redundant tests and adjust benchmarking.

Remove the experimental / unused parquet and duckdb receipt store.
Remove redundant tests and adjust benchmarking.
@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJun 12, 2026, 4:59 PM

@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.35%. Comparing base (0a2c388) to head (ed3e474).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3580      +/-   ##
==========================================
- Coverage   59.22%   58.35%   -0.87%     
==========================================
  Files        2214     2140      -74     
  Lines      183389   174791    -8598     
==========================================
- Hits       108604   101999    -6605     
+ Misses      64994    63701    -1293     
+ Partials     9791     9091     -700     
Flag Coverage Δ
sei-chain-pr 59.46% <100.00%> (?)
sei-db 70.41% <ø> (ø)
sei-db-state-db ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/test_helpers.go 72.07% <ø> (ø)
evmrpc/filter.go 65.68% <ø> (ø)
sei-db/config/receipt_config.go 77.77% <100.00%> (-1.39%) ⬇️
sei-db/ledger_db/receipt/receipt_store.go 65.77% <100.00%> (-0.90%) ⬇️
sei-db/ledger_db/receipt/tx_hash_index.go 69.52% <ø> (+4.86%) ⬆️

... and 74 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@masih masih marked this pull request as ready for review June 12, 2026 16:43
@masih masih requested review from Kbhat1 and cody-littley June 12, 2026 16:43
@cursor

cursor Bot commented Jun 12, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Large removal of an alternate receipt persistence path and log/receipt query code; production impact is low if parquet was never enabled, but operators or branches still setting rs-backend=parquet will fail at startup.

Overview
Removes the experimental parquet/DuckDB EVM receipt store and everything that depended on it, leaving pebbledb as the only supported rs-backend.

The sei-db/ledger_db/parquet package (DuckDB reader, parquet writers, WAL, pruning) and the cachedReceiptStore wrapper are deleted, along with parquet-specific receipt wiring and tests. Config no longer accepts parquet or tx-index-backend; templates and validation only document pebble/pebbledb.

Docker/Makefile parquet cluster targets (docker-cluster-start-parquet, parquet-integration-test, docker-compose.parquet.yml, evm_parquet_tests.sh) and the large ParquetReceiptTest.js Hardhat suite are removed. Giga Storage defaults for RECEIPT_BACKEND switch from parquet to pebble in local node scripts.

Dependencies drop duckdb-go, parquet-go, and related transitive modules from go.mod/go.sum. evmrpc comments are generalized (no parquet-specific backend names).

Reviewed by Cursor Bugbot for commit ed3e474. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread sei-db/state_db/bench/cryptosim/reciept_store_simulator.go

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0fca0ae6f9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@@ -142,13 +141,12 @@ func NewRecieptStoreSimulator(
Backend: "parquet",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use a supported receipt backend in cryptosim

When the cryptosim receipt simulator is created, this hard-coded Backend: "parquet" now goes through receipt.NewReceiptStoreWithReadMetrics, but this commit removed the parquet implementation and newReceiptBackend only accepts the pebble backend. As a result any cryptosim run that enables receipt generation/reads fails during simulator initialization with unsupported receipt store backend: parquet, so the receipt benchmark can no longer start.

Useful? React with 👍 / 👎.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ed3e474. Configure here.

"os"
"path/filepath"
"sync"
"time"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused tx hash index code

Low Severity

The parquet receipt store and its tx-hash index wiring are removed, yet PebbleTxHashIndex and related APIs in tx_hash_index.go have no callers outside their tests. That unused surface suggests the parquet-specific index path was not fully removed with the backend.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit ed3e474. Configure here.

@cody-littley cody-littley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please get signoff with @Kbhat1 before merging, as he's currently in charge of managing all recieptDB stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants