test: securesign-5860: remove linux/amd64 skip from tufcli tests

[kdacosta0]

What changed: Removed the platform check that skipped the tufcli end-to-end test on anything other than linux/amd64.

Why: The restriction came from the old Rust-based tuftool, which only shipped for that one platform. tufcli is built and published for every supported OS and architecture, so the skip was needlessly reducing test coverage.

🤖 Generated with Claude Code

Test run: https://github.com/securesign/releases/actions/runs/37595946235

[qodo-for-securesign]

PR Summary by Qodo

Run tufcli end-to-end tests on all supported platforms

🧪 Tests 🕐 Less than 10 minutes

AI Description

• Remove the linux/amd64 skip from the tufcli manual-repository test.
• Restore test coverage on other supported platforms, where tufcli is also available.

Diagram

graph TD
  A["Manual TUF test"] --> B["Install prerequisites"] --> C["Tufcli setup strategy"] --> D["Tufcli commands"] --> E["Repository files"]

Loading

High-Level Assessment

Removing the obsolete guard is the simplest way to restore coverage. Replacing it with a supported-platform list would duplicate platform availability information and require ongoing maintenance.

Files changed (1) +0 / -7

Tests (1) +0 / -7

tufcli_manual_tuf_repo_test.goRemove the tufcli test's linux/amd64 gate +0/-7

Remove the tufcli test's linux/amd64 gate

• Removes the OpenShift-strategy platform check that skipped the ordered manual-repository test outside linux/amd64. Also removes the runtime and API imports that the check alone used.

test/tufcli/tufcli_manual_tuf_repo_test.go

[qodo-for-securesign]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

1. Windows release validation now fails ✓ Resolved

Description

verifyWorkdirStructure compares native paths returned by filepath.Rel with slash-separated
expected names and a tuf-repo/targets/ prefix. With the platform skip removed, the
securesign/releases Windows runner supplies backslash-separated paths for the generated TUF
repository, so the directory, file, and targets-prefix checks can fail despite successful repository
creation.

Code

test/tufcli/tufcli_manual_tuf_repo_test.go[L46-48]

-		if openshiftStrategyActive && (runtime.GOOS != "linux" || runtime.GOARCH != "amd64") {
-			logrus.Info("Skipping tufcli download test: openshift strategy is only supported on linux/amd64")
-			Skip("Skipping tufcli download test: openshift strategy is only supported on linux/amd64")

Relevance

●●● Strong

Accepted Windows portability fixes show the team prioritizes cross-platform test reliability; this
path-separator bug is concrete.

PR-#98
PR-#94

ⓘ Recommendations generated based on similar findings in past PRs

Evidence

The test calls verifyWorkdirStructure after repository setup, then uses unnormalized
filepath.Rel results as map keys and in the targets-prefix check against slash-separated values.
tufcli creates the targets directory with filepath.Join, and the releases workflow runs the
newly enabled test on Windows, where relative paths use backslashes.

sigstore-e2e -> tufcli
sigstore-e2e -> releases
test/tufcli/tufcli_manual_tuf_repo_test.go[184-235]
test/tufcli/tufcli_manual_tuf_repo_test.go[56-60]
test/tufcli/tufcli_manual_tuf_repo_test.go[177-201]
test/tufcli/tufcli_manual_tuf_repo_test.go[224-250]
External repo: securesign/tufcli, internal/create/create.go [109-115]
External repo: securesign/releases, .github/workflows/cross-platform-tests.yml [447-454]
External repo: securesign/releases, .github/workflows/cross-platform-tests.yml [518-537]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Removing the platform skip makes the manual TUF repository test run in the releases repository’s Windows workflow, but its structure assertions compare native Windows paths with slash-separated expected paths.

## Fix Focus Areas
- test/tufcli/tufcli_manual_tuf_repo_test.go[188-250]

## Recommended Fix
Convert each `filepath.Rel` result with `filepath.ToSlash` before using it for directory names, file names, or the targets-prefix check. Keep the test enabled on Windows.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

Context sources

✅ Cross-repo context — repo relationships

  Explored: repo: securesign/releases (sha: e5fe10fb) — View relationship

  Explored: repo: securesign/tufcli (sha: d31b50ea) — View relationship

Review mode: Auto: ⚖️ Balanced: Removes platform gating from cross-platform end-to-end test behavior.

Tip of the day

💡 Did you know, you can route each severity your way: inline, summary, both, or drop

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗