Skip to content

ldaphero: add 'no check certificate' box #5293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpotter2 merged 1 commit into from
Nov 13, 2026
Merged

ldaphero: add 'no check certificate' box #5293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions scapy/modules/ldaphero.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ def __init__(
host: str = None,
port: int = None,
ssl: bool = False,
no_check_certificate=False,
# Authentication
UPN: str = None,
password: str = None,
Expand Down Expand Up @@ -203,6 +204,7 @@ def __init__(
self.host = host
self.port = port
self.ssl = ssl
self.no_check_certificate = no_check_certificate
self.dns_domain_name = ""
self.rootDSE = {}
self.sids = dict(WELL_KNOWN_SIDS)
Expand Down Expand Up @@ -241,11 +243,17 @@ def connect(self):
tk.Entry(dlg, textvariable=portv).grid(row=1, column=1)

sslv = tk.BooleanVar()
sslv.set(self.ssl)
ttk.Label(dlg, text="SSL").grid(row=2, column=0)
ttk.Checkbutton(dlg, variable=sslv).grid(row=2, column=1)

ttk.Button(dlg, text="OK", command=popup.dismiss).grid(row=3, column=0)
ttk.Button(dlg, text="Cancel", command=popup.cancel).grid(row=3, column=1)
nccv = tk.BooleanVar()
nccv.set(self.no_check_certificate)
ttk.Label(dlg, text="Do not check certificate").grid(row=3, column=0)
ttk.Checkbutton(dlg, variable=nccv).grid(row=3, column=1)

ttk.Button(dlg, text="OK", command=popup.dismiss).grid(row=4, column=0)
ttk.Button(dlg, text="Cancel", command=popup.cancel).grid(row=4, column=1)

serverf.focus()

Expand All @@ -261,14 +269,20 @@ def connect(self):
except ValueError:
return
self.ssl = sslv.get()
self.no_check_certificate = nccv.get()

# Connect now !
self.tprint(
"client.connect(host='%s', port=%s, ssl=%s)"
% (self.host, self.port, self.ssl)
"client.connect(host='%s', port=%s, ssl=%s, no_check_certificate=%s)"
% (self.host, self.port, self.ssl, self.no_check_certificate)
)
try:
self.client.connect(self.host, port=self.port, use_ssl=self.ssl)
self.client.connect(
self.host,
port=self.port,
use_ssl=self.ssl,
no_check_certificate=self.no_check_certificate,
)
except Exception as ex:
self.tprint(str(ex))
self.host = None
Expand Down
Loading