Repository navigation
kerberos/ntlm: check sequence numbers - #5291
Merged
Merged
Conversation
gpotter2
commented
Nov 12, 2026
Member
- properly check sequence numbers in Kerberos & NTLM
AI-Assisted: yes (Codex GPT-6.1-Sol)
gpotter2
commented
Nov 12, 2026
| assert passiveContext.ssp_context.passive | ||
|
|
||
| = GSS_Accept_sec_context rejects a replayed AP-REQ | ||
| = GSS_Accept_sec_context rejects a replayed AP-REQ without the replay flag |
Member
Author
There was a problem hiding this comment.
Suggested change
| = GSS_Accept_sec_context rejects a replayed AP-REQ without the replay flag | |
| = GSS_Accept_sec_context rejects a replayed AP-REQ |
gpotter2
commented
Nov 12, 2026
| return Context, err, gssErrorCode | ||
|
|
||
| # Store the time for future detections | ||
| # Cache authenticators to avoid replay |
Member
Author
There was a problem hiding this comment.
Suggested change
| # Cache authenticators to avoid replay | |
| # Store the time for future detections |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5291 +/- ##
==========================================
- Coverage 80.66% 80.15% -0.52%
==========================================
Files 375 375
Lines 98750 98766 +16
==========================================
- Hits 79661 79169 -492
- Misses 19089 19597 +508
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.