Load MANUFDB lazily - #5203
Open
frenck wants to merge 1 commit into
Open
Load MANUFDB lazily#5203frenck wants to merge 1 commit into
frenck wants to merge 1 commit into
Conversation
scapy.data loaded the manuf database at import time, which takes about 12 MiB of memory even when it is never used. Load it on first access through a module __getattr__ instead. AI-Assisted: yes
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5203 +/- ##
=======================================
Coverage 81.16% 81.17%
=======================================
Files 393 393
Lines 98107 98114 +7
=======================================
+ Hits 79629 79640 +11
+ Misses 18478 18474 -4
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
scapy.data loaded the manuf database at import time, which takes about 12 MiB of memory even when it is never used. Load it on first access through a module getattr instead.
AI-Assisted: yes
This change will reduce the memory footprint of Home Assistant with 10+MiB basically for free; which in today's memory crisis, is a quick but big win.
../Frenck
Blogging my personal ramblings at frenck.dev