Feature: CAN XL Support - #5152
Open
RB-FriedrichWiemer wants to merge 17 commits into
Open
RB-FriedrichWiemer wants to merge 17 commits into
RB-FriedrichWiemer wants to merge 17 commits into
Conversation
Introduce the CANXL class in scapy.layers.can, following the Linux struct canxl_frame wire format and inheriting from the CAN class. Provides additional ISO 11898-1:2024 property accessors and show(style='11898-1') for ISO field-name rendering. AI-Assisted: yes (Claude Opus and Sonnet)
AI-Assisted: yes (Claude Opus and Sonnet)
AI-Assisted: yes (Claude Opus and Sonnet)
Tests pass on Linux. On Windows, tests appear to timeout -- needs further investigation. AI-Assisted: yes (Claude Opus and Sonnet)
Covers quick start, field naming (Linux vs ISO), byte-order handling, NativeCANSocket usage, can-utils interop, and known limitations. AI-Assisted: yes (Claude Opus and Sonnet)
AI-Assisted: yes (Claude Opus and Sonnet)
Contributor
|
Thanks for this PR. Please resolve the conflicts with the master. |
polybassa
reviewed
Sep 8, 2026
polybassa
reviewed
Sep 8, 2026
polybassa
reviewed
Sep 8, 2026
polybassa
reviewed
Sep 8, 2026
polybassa
reviewed
Sep 8, 2026
polybassa
reviewed
Sep 8, 2026
polybassa
reviewed
Sep 8, 2026
polybassa
reviewed
Sep 8, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5152 +/- ##
===========================================
- Coverage 80.96% 47.46% -33.50%
===========================================
Files 390 372 -18
Lines 96994 96755 -239
===========================================
- Hits 78530 45926 -32604
- Misses 18464 50829 +32365
🚀 New features to boost your workflow:
|
RB-FriedrichWiemer
changed the title
|
the byte-swap for wireshark pcaps I still need to check |
polybassa
reviewed
Sep 22, 2026
polybassa
left a comment
polybassa
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Let's check what wireshark does, then we can merge
Contributor
|
Please fix the failing job. |
polybassa
approved these changes
Sep 25, 2026
AI-Assisted: no
Declare the CAN XL header as little endian via BitField's tot_size / end_tot_size, LEShortField and XLEIntField, instead of swapping the prio, length and af regions by hand. Removes CANXL.inv_endianness() and the swap in pre_dissect() and post_build(). AI-Assisted: yes (Claude Opus and Sonnet)
post_dissect duplicated CAN.post_dissect, and the default guess_payload_class already returns conf.raw_layer when no payload class is bound. AI-Assisted: yes (Claude Opus and Sonnet)
Keep Packet.show()'s signature unchanged and expose the ISO 11898-1 rendering as its own method. AI-Assisted: yes (Claude Opus and Sonnet)
Use Packet.sprintf() for the fields it can resolve instead of formatting each one against the color theme by hand. Format, FTYPE, SEC and DLC are properties rather than fields, so they stay resolved in Python. AI-Assisted: yes (Claude Opus and Sonnet)
Both recv_raw() and send() open-coded the same four-byte swap that CAN.inv_endianness() already performs. Also drops _is_canxl(), a single-use wrapper around CANXL.is_canxl_frame(). AI-Assisted: yes (Claude Opus and Sonnet)
AI-Assisted: yes (Gemini 3.8 Flash)
…rt' into feature/canxl-support
pfasante
force-pushed
the
feature/canxl-support
branch
from
September 25, 2026 22:30
99486a3 to
ed1f066
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is my first pull request to scapy.
It adds CAN XL support to the existing CAN layer, making use of the CAN XL implementation available on Linux' SocketCAN.