Use httpbingo.org instead of httpbin.seatsio.net#262
Merged
Conversation
mroloux
requested review from
bverbeken,
Copilot and
schaloner
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the test suite to use httpbingo.org instead of httpbin.seatsio.net for simulating specific HTTP error responses and timeout behavior.
Changes:
- Switched external test endpoints from
https://httpbin.seatsio.net/...tohttps://httpbingo.org/.... - Updated expected exception messages in tests to reflect the new host.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/test/java/seatsio/ExponentialBackoffTest.java | Updates the status endpoints used for 400/429 and the corresponding asserted exception messages. |
| src/test/java/seatsio/ErrorHandlingTest.java | Updates the 500 and delay/timeout endpoints and the corresponding asserted exception messages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| throw new RuntimeException("Should have failed"); | ||
| } catch (SeatsioException e) { | ||
| assertThat(e.getMessage()).isEqualTo("GET https://httpbin.seatsio.net/status/400 resulted in a 400 Bad Request response. Body: "); | ||
| assertThat(e.getMessage()).isEqualTo("GET https://httpbingo.org/status/400 resulted in a 400 Bad Request response. Body: "); |
| throw new RuntimeException("Should have failed"); | ||
| } catch (SeatsioException e) { | ||
| assertThat(e.getMessage()).isEqualTo("GET https://httpbin.seatsio.net/status/429 resulted in a 429 Too Many Requests response. Body: "); | ||
| assertThat(e.getMessage()).isEqualTo("GET https://httpbingo.org/status/429 resulted in a 429 Too Many Requests response. Body: "); |
| SeatsioException e = assertThrows(SeatsioException.class, () -> new UnirestWrapper("secretKey", null).stringResponse(get("https://httpbin.seatsio.net/status/500"))); | ||
| assertThat(e.getMessage()).isEqualTo("GET https://httpbin.seatsio.net/status/500 resulted in a 500 Internal Server Error response. Body: "); | ||
| SeatsioException e = assertThrows(SeatsioException.class, () -> new UnirestWrapper("secretKey", null).stringResponse(get("https://httpbingo.org/status/500"))); | ||
| assertThat(e.getMessage()).isEqualTo("GET https://httpbingo.org/status/500 resulted in a 500 Internal Server Error response. Body: "); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.