Skip to content

docs: trivial fixes#533

Open
yf13 wants to merge 1 commit into
seL4:mainfrom
yf13:pull-manual-fixes
Open

docs: trivial fixes#533
yf13 wants to merge 1 commit into
seL4:mainfrom
yf13:pull-manual-fixes

Conversation

@yf13

@yf13 yf13 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Some trivial fixes in manual.md like:

  • Add missing (gdb) before GDB comments so that markdown tools don't take them as new title lines.
  • Add missing break in 10.2 so that list is correctly rendered in PDF version.

@lsf37

lsf37 commented Jun 21, 2026

Copy link
Copy Markdown
Member

These files are generated. Has the same change been made upstream?

@midnightveil

Copy link
Copy Markdown
Collaborator

These files are generated. Has the same change been made upstream?

Unless I'm mistaken this is the upstream and seL4 docs sources off the microkit manual?

Comment thread docs/manual.md Outdated
2. Set the `a0` and `a1` registers for OpenSBI

# tell OpenSBI where DTB is (there is none)
(gdb) # tell OpenSBI where DTB is (there is none)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather these be placed in backticks ``` and indentation removed, I think.

IDK why the markdown parswr would be parsing headings when its indented for a coxe block...

@midnightveil midnightveil Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the manual PDF and GitHub both parse this correctly?

I don't understand this change.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Standard markdown specs would definitely not parse this as heading. Indented code blocks are not an exotic feature, but putting it into a fenced code block like @midnightveil suggests would fix any ambiguity if you want to be extra sure.

Adding (gdb) seems not good to me, because (gdb) is the prompt and the line is supposed to be a comment between prompts.

@yf13 yf13 Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It turned out that I was misled by the outline plugin in my text editor:

image

Anyway, I can ignore it now as it looks like a bug of that plugin.

I've updated the commit to keep original form as it is following markdown rule.

@lsf37

lsf37 commented Jun 22, 2026

Copy link
Copy Markdown
Member

These files are generated. Has the same change been made upstream?

Unless I'm mistaken this is the upstream and seL4 docs sources off the microkit manual?

Wow, yes, I don't know how I hallucinated the docs repo here. Apologies. This is absolutely the right repo for this change.

Some trivial fixes in manual.md like:
- Add missing break in 10.2 so that list is correctly rendered in
  PDF version.

Signed-off-by: Yanfeng Liu <yfliu2008@qq.com>
@yf13 yf13 force-pushed the pull-manual-fixes branch from 3c53d0e to fc38be2 Compare June 22, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants