feat: add configurable columns to PAGA plots - #4325
Conversation
Signed-off-by: AtomicGlance <amiralimoradniaei@gmail.com>
|
The code and focused tests are in place. One repository metadata check is failing only because this fork PR cannot add the required no milestone label without upstream permissions. Could a maintainer add that label or assign a milestone? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4325 +/- ##
==========================================
- Coverage 81.98% 81.88% -0.11%
==========================================
Files 134 134
Lines 13235 13254 +19
==========================================
+ Hits 10851 10853 +2
- Misses 2384 2401 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: AtomicGlance <amiralimoradniaei@gmail.com>
|
Thanks for flagging this. I added coverage for invalid ncols values, the ncols plus pre-supplied ax error, and a custom colorbar axis, then pushed b6c4457. The focused PAGA tests now pass 11 cases; Codecov should rerun on the new commit. |
|
CI reran on the latest commit. The PAGA-focused tests pass and Codecov reports 100% patch coverage.\n\nThe remaining Python 3.14 failure is unrelated to this change: ests/test_logging.py::test_logfile finishes with 3,033 tests passed and one teardown error from an unclosed-file ResourceWarning. That test is unchanged in this PR and the diff is limited to PAGA code, tests, and the release-note fragment, so I have not added an unrelated fix.\n\nThe title/milestone/labels check is also still blocked because this fork cannot add the repository's no-milestone label or assign a milestone. Could a maintainer handle that metadata check and advise whether the Python 3.14 logging failure should be rerun or tracked upstream? |
Summary
Closes #1203
Tests