feat: support acc shortcuts - #4288
Conversation
❌ 16 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
selmanozleyen
left a comment
There was a problem hiding this comment.
Hi,
this looks nice but if we want to ensure people use the accessors why do we allow strings then? Because I think there are some problems with the string format I'd like to mention first. I know it's not entirely in the scope of this PR but since we are exposing it here I find it relevant.
Also since the checks in the str format isn't robust and complete it might cause some confusion in scanpy. One more comment on . as the separator. I know that seurat v5 uses . uses it as a separator for example like layers[counts.sample1]
@timtreis and others seem to feel strong about it … |
|
TODO: think about shortcuts and dataframes: Maybe just ban dots in keys? |
scanpy.get.aggregatealready handles them, but the plotting functions didn’t yet.