add backends - #4108
Open
Intron7 wants to merge 10 commits into
Open
Conversation
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
# Conflicts: # pyproject.toml # src/scanpy/get/_aggregated.py # src/scanpy/preprocessing/_pca/__init__.py # src/scanpy/tools/_diffmap.py # src/scanpy/tools/_embedding_density.py # src/scanpy/tools/_rank_genes_groups.py
flying-sheep
left a comment
flying-sheep
left a comment
Member
There was a problem hiding this comment.
looks good! I didn’t look at the test yet (I will once you mark it ready for review)
Comment on lines
+186
to
+190
| def use_backend(self, backend: str): | ||
| """Temporarily set the active computational backend.""" | ||
| from .._backends import settings as backend_settings | ||
|
|
||
| return backend_settings.use_backend(backend) |
Member
There was a problem hiding this comment.
this should be removed, sc.settings.override(backend=...) exists, and if it doesn’t work for some reason, we should fix that
Comment on lines
+198
to
+202
| def get_backend(self, name: str): | ||
| """Look up an installed computational backend by name or alias.""" | ||
| from .._backends import settings as backend_settings | ||
|
|
||
| return backend_settings.get_backend(name) |
Member
There was a problem hiding this comment.
Why does this exist? Does the user ever need to access the backend object?
| return FakeRapidsBackend | ||
|
|
||
|
|
||
| DISPATCHED_FUNCTIONS = [ |
Member
There was a problem hiding this comment.
I don’t want to keep this in sync. Can’t the decorator just populate a list that we can access here?
One thing to note is that it probably can’t just put its function argument in the list, as other decorators might be applied after this one.
| "pynndescent>=0.5.13", | ||
| "scikit-learn>=1.6", | ||
| "scipy>=1.15", | ||
| "scverse-backends>=0.0.3,<0.1", |
Member
There was a problem hiding this comment.
this has no dependencies right?
Member
Author
There was a problem hiding this comment.
No None. I'll also remove the pin
Co-authored-by: Philipp A. <flying-sheep@web.de>
grst
reviewed
Aug 20, 2026
| host_name="scanpy", | ||
| trusted_backends={ | ||
| "rapids-singlecell": { | ||
| "aliases": ["cuda", "rapids", "rapids_singlecell"], |
Contributor
There was a problem hiding this comment.
Does it make sense to have that many aliases that mean the same thing? Could be confusing.
I think aliases are mostly useful for backwards-compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sc.get.aggregate.scverse-backends>=0.0.3and exercise its lazy entry-point discovery and automatic backend-parameter signature injection.main, preserving upstream API changes alongside dispatch decorators.Validation
uv run --group test pytest -q tests/test_backends.py tests/test_package_structure.py::test_sig_conventionsuv run --group test pytest -q tests/test_aggregated.py tests/test_pca.py tests/test_embedding.py tests/test_rank_genes_groups.py