Skip to content

Fix adding hook in KeyboardView to dismiss the active popup keys on hide #635

Merged
angrezichatterbox merged 1 commit into
scribe-org:mainfrom
Roniscend:Keyboard-bug
Jun 27, 2026
Merged

Fix adding hook in KeyboardView to dismiss the active popup keys on hide #635
angrezichatterbox merged 1 commit into
scribe-org:mainfrom
Roniscend:Keyboard-bug

Conversation

@Roniscend

Copy link
Copy Markdown
Contributor

Contributor checklist


Description

Add cleanup hook in KeyboardView's onVisibilityChanged to dismiss active popup keys on hide

Fixes- #634

Copilot AI review requested due to automatic review settings June 27, 2026 07:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown

Thank you for the pull request! 💙🩵

The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and Android rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions

github-actions Bot commented Jun 27, 2026

Copy link
Copy Markdown

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@angrezichatterbox angrezichatterbox self-requested a review June 27, 2026 09:16
@angrezichatterbox angrezichatterbox linked an issue Jun 27, 2026 that may be closed by this pull request
2 tasks
@angrezichatterbox angrezichatterbox merged commit c72f797 into scribe-org:main Jun 27, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix long-press popup keyboard state persistence when hidden

3 participants