Skip to content

Implement Conjugate Data in UI#625

Open
angrezichatterbox wants to merge 11 commits into
scribe-org:mainfrom
angrezichatterbox:feature/implement-conjugate-data-for-ui
Open

Implement Conjugate Data in UI#625
angrezichatterbox wants to merge 11 commits into
scribe-org:mainfrom
angrezichatterbox:feature/implement-conjugate-data-for-ui

Conversation

@angrezichatterbox

@angrezichatterbox angrezichatterbox commented Jun 24, 2026

Copy link
Copy Markdown
Member

Contributor checklist


Description

This PR adds the conjuagte view and handling for english and swedish

Related issue

@github-actions

Copy link
Copy Markdown

Thank you for the pull request! 💙🩵

The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and Android rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions

Copy link
Copy Markdown

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review June 25, 2026 14:20
@andrewtavis

Copy link
Copy Markdown
Member

@angrezichatterbox, do you want to fix the linting errors? I can then do a review. Note that I've also edited your commit message to close the issues via our conversation :)

@andrewtavis

andrewtavis commented Jun 26, 2026

Copy link
Copy Markdown
Member

Minor points here that we could do as a part of this, @angrezichatterbox:

  • We don't have a tooltip for the Conjugate screen and the one for the settings screen references language keyboard, which is misleading
    • I just updated Scribe-i18n with i18n.app.settings.keyboard_app_hint_tooltip, i18n.app.settings.conjugate_app_hint_tooltip and i18n.app.conjugate.app_hint_tooltip
  • There's a weird shadow effect under the search bar that looks like it's being cut off below the button (see the shadow below the corners)
Screenshot 2026-06-26 at 17 21 00
  • Let's get rid of the quick tutorial menu option in the About tab for the conjugate app (I think that Scribe-Conjugte should be easier enough for the user to understand that we don't need a tutorial)

Aside from the above, this is a solid WIP! Will give it a final check and bring it in once the above's done 😊

@angrezichatterbox

Copy link
Copy Markdown
Member Author

@andrewtavis this is ready for review : )

@andrewtavis

Copy link
Copy Markdown
Member

Amazing, @angrezichatterbox!

Note: @prince-0408 that the changes for Scribe-i18n will come in via this PR, so you'll need to rebase your PR with the new version of Scribe-Android and Scribe-i18n once this is brought in.

@prince-0408

Copy link
Copy Markdown
Contributor

Amazing, @angrezichatterbox!

Note: @prince-0408 that the changes for Scribe-i18n will come in via this PR, so you'll need to rebase your PR with the new version of Scribe-Android and Scribe-i18n once this is brought in.

Thanks for the heads-up, @andrewtavis ! I'll keep an eye on this and rebase my branch/sync the submodule pointer once PR this is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow the user to filter for conjugations by tense Populate Conjugate search UI with verbs from the DB

3 participants