Add Korean alternative date expressions#1289
Merged
serhii73 merged 3 commits intoJun 9, 2026
Merged
Conversation
Contributor
|
I see no YAML file edited, which makes me think you might have not seen https://dateparser.readthedocs.io/en/latest/contributing.html#guidelines-for-editing-translation-data. |
seungwoo-ji-03
force-pushed
the
feat/add_Korean_alternative_date_expressions
branch
from
2a72767 to
9175252
Compare
Contributor
Author
My bad, I updated files |
Resolve conflict in the generated dateparser/data/date_translation_data/ko.py by regenerating it from the supplementary ko.yaml with the current generator. Master moved the relative-type-regex digit quantifiers to the possessive form (\d++[.,]?\d*+), so the new "달" (month) patterns are now emitted in that same form, keeping the generated data consistent with the rest of master. Verified: - generator reproduces all other committed data files byte-for-byte - test_dateparser_data_integrity passes (committed data == generator output) - full test suite passes (24055 passed, 18 skipped, 1 xfailed) - ruff check / format clean Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1289 +/- ##
=======================================
Coverage 97.11% 97.11%
=======================================
Files 235 235
Lines 2909 2909
=======================================
Hits 2825 2825
Misses 84 84 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
AdrianAtZyte
approved these changes
Jun 9, 2026
Collaborator
|
Thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for formal and colloquial Korean date expressions to improve parsing coverage.
Formal expressions (격식체):
금일- formal variant of오늘(today)작일- formal variant of어제(yesterday)명일- formal variant of내일(tomorrow)Colloquial expressions (구어체):
달- colloquial alternative to개월(month)3달 전(3 months ago),2달 후(in 2 months)