test: known host fixes and improvements - #1704
Merged
Merged
Conversation
Matching against the combined set would require setting BASH_COMPLETION_KNOWN_HOSTS_WITH_AVAHI in everything that tests hosts.
BASH_COMPLETION_KNOWN_HOSTS_WITH_AVAHI needs to be non-empty for completion to produce the same entries that our avahi hosts fixture does.
akinomyoga
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits for details.
This is primarily to make tests work as appropriate on setups where avahi-browse contributes something.
This stuff is still not pretty, but at least now it works for me locally (where avahi-browse does find things).