Skip to content

Update ics-py - #144

Merged
jarrodmillman merged 4 commits into
scientific-python:mainfrom
jarrodmillman:ics-v0.8.0-dev1
Nov 4, 2026
Merged

jarrodmillman merged 4 commits into
scientific-python:mainfrom
jarrodmillman:ics-v0.8.0-dev1

Conversation

@jarrodmillman

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.26%. Comparing base (b0176a1) to head (2fafdc3).
⚠️ Report is 45 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
- Coverage   95.41%   94.26%   -1.16%     
==========================================
  Files           1        1              
  Lines         109      122      +13     
==========================================
+ Hits          104      115      +11     
- Misses          5        7       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jarrodmillman
jarrodmillman marked this pull request as draft November 3, 2026 17:44

@bsipocz bsipocz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have #134, but I agree that we should go ahead with one or the other.

matrix:
os: [ubuntu, macos, windows]
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13", "3.14-dev"]
python-version: ["3.10", "3.11", "3.12", "3.13", "3.14", "3.15"]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.10 is at EOL, maybe we can drop it, too?

@jarrodmillman jarrodmillman Nov 4, 2026 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I was thinking to merge this and then merge #142.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, the main issue with #142 is still that there is no new release for https://github.com/ics-py/ics_vtimezones since Stefan's fix, so maybe we need to pin a dev version?

@jarrodmillman
jarrodmillman marked this pull request as ready for review November 4, 2026 08:04
@jarrodmillman
jarrodmillman merged commit 41ad995 into scientific-python:main Nov 4, 2026
21 of 22 checks passed
@stefanv stefanv added this to the 0.4 milestone Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants