Skip to content

Add lychee link checker workflow - #725

Open
InessaPawson wants to merge 4 commits into
scientific-python:mainfrom
InessaPawson:lychee
Open

InessaPawson wants to merge 4 commits into
scientific-python:mainfrom
InessaPawson:lychee

Conversation

@InessaPawson

Copy link
Copy Markdown
Member

Closes #702.

Needs a type: label, I don't have permissions to do it.

The workflow is set to fail: false for us to see what the first runs report. Once the existing broken links are fixed, I'd recommend flipping it to fail: true so broken links are treated as errors by CI.

@netlify

netlify Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

❌ Deploy Preview for scientific-python-hugo-theme failed.

Built without sensitive environment variables

Name Link
🔨 Latest commit a012440
🔍 Latest deploy log https://app.netlify.com/projects/scientific-python-hugo-theme/deploys/6ac0273d5c6a060008cf8d92

Comment thread .github/workflows/linkcheck.yaml Outdated
Comment thread lychee.toml Outdated
Comment thread Makefile Outdated
InessaPawson and others added 3 commits October 2, 2026 17:37
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
@InessaPawson

Copy link
Copy Markdown
Member Author

@agriyakhetarpal I checked the Netlify build log to see why CI fails here when the build works for me locally. The learn Makefile target fails because learn.scientific-python.org migrated from Hugo to MyST (scientific-python/learn.scientific-python.org#315). This will break every deploy preview until learn is dropped from the netlify-preview target. Happy to open a separate PR for that if it would be helpful.

@agriyakhetarpal

Copy link
Copy Markdown
Member

@agriyakhetarpal I checked the Netlify build log to see why CI fails here when the build works for me locally. The learn Makefile target fails because learn.scientific-python.org migrated from Hugo to MyST (scientific-python/learn.scientific-python.org#315). This will break every deploy preview until learn is dropped from the netlify-preview target. Happy to open a separate PR for that if it would be helpful.

Good point, @InessaPawson. I think we should indeed drop the learn site in a separate PR. Thanks for addressing my feedback so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use Lychee as link checker

2 participants