Repository navigation
Treat minus as a number separator in FLOAT_CMP - #328
Open
abhishekcpp007 wants to merge 2 commits into
Open
abhishekcpp007 wants to merge 2 commits into
abhishekcpp007 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
front_sep = r'\s|[*+-,<=(\[]'the+-,is a character range from+to,, so-isn't a separator. Numbers right after a-aren't found, and a complex repr with a negative imaginary part fails underFLOAT_CMP:The first passes and the second fails with
Got: (1.5-2.50000001j). Escaping the-fixes it. A flipped sign like(1.5+2.5j)vs(1.5-2.5j)still fails.Added
test_float_cmp_complexnext totest_float_cmp_dictand a changelog entry.