optical stim: support runtime display pin map#188
Open
namthor9 wants to merge 1 commit into
Open
Conversation
Add display_map (row_map/col_map) support to the OpticalStimulation client node: __init__ params with validation (dims <= 128, pins <= 255, paired, pixel_mask consistency) and full _to_proto/_from_proto round-trip. Add ready-made pin maps for the known displays. Show the configured display dimensions in the CLI device info. Depends on the synapse-api DisplayMap change; the synapse-api submodule must be bumped (and bindings regenerated) after that merges.
namthor9
force-pushed
the
maxr/optical-stim-display-map
branch
from
40e12f6 to
3a4b640
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
display_map(row_map/col_map) support to theOpticalStimulationclient node:__init__params with validation (dims ≤ 128, pins ≤ 255, both-or-neither, pixel_mask length consistency)_to_proto/_from_protoround-trip (viaHasField('display_map'))Dependency
Depends on sciencecorp/synapse-api#83 (the
DisplayMapproto). Thesynapse-apisubmodule must be bumped and the generated bindings regenerated (setup.sh) after that merges. Generated*_pb2.pyare gitignored, so they are intentionally not in this diff.