Skip to content

Drop "to every loop" from the broadcast text (#375) - #389

Merged
scgopi merged 1 commit into
mainfrom
fix/375-broadcast-prefix
Sep 19, 2026
Merged

scgopi merged 1 commit into
mainfrom
fix/375-broadcast-prefix

Conversation

@scgopi

@scgopi scgopi commented Sep 19, 2026

Copy link
Copy Markdown
Owner

Summary

Drops "to every loop" from the text a broadcast types into each session. Follow-up to #382 (#375).

Changes

  • A broadcast now reads exactly like a graphcode node send: [graphcode] Sender: text, or [graphcode] text when a human sends it.
  • Before, every recipient saw [graphcode] to every loop — …, read it as a cue to address every loop itself, and a single broadcast set the whole graph messaging in circles.
  • The Mailroom still records one @all letter per broadcast; only the text typed into sessions changes.

Test plan

RED: xcodebuild test -only-testing:graphcodeTests/BroadcastMessageTests with the updated expectations on main's GraphStore.swift -> exit 65, TEST FAILED: delivered text and staged memo still carry "to every loop"
GREEN: xcodebuild test -only-testing:graphcodeTests/BroadcastMessageTests -> exit 0, 6 tests in 1 suite passed
REGRESSION: xcodebuild -scheme graphcode test, graphcoded and graphcode-cli builds, make check, swift test --package-path investigation/spikes/swift-portable -> exit 0, 1895 tests in 199 suites passed; both schemes build; make check clean; portable package passes

Checklist

  • I have read the Contributing Guidelines
  • I have signed off my commits (git commit -s) per the DCO
  • Tests pass locally (make test)
  • Code follows the existing style (make check)
  • I added the test/contract before the implementation and observed the intended RED failure

Every recipient of a broadcast read "[graphcode] to every loop — …" as a
cue to address every loop itself, so a single broadcast set the graph
talking in circles. A broadcast now reads exactly like a `node send`:
"[graphcode] Sender: text", or "[graphcode] text" from a human.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: scgopi <scgopireddy@gmail.com>
@scgopi
scgopi force-pushed the fix/375-broadcast-prefix branch from 137f66d to e6c947f Compare September 19, 2026 03:40
@scgopi
scgopi merged commit f06b880 into main Sep 19, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant