Repository ingress and settings/worktree parity polish - #387
Merged
Merged
Conversation
Signed-off-by: Colin Neilens <coneilen@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 45640a35-85a6-4f48-a737-4892cce9b34c
Signed-off-by: Colin Neilens <coneilen@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 45640a35-85a6-4f48-a737-4892cce9b34c
Signed-off-by: Colin Neilens <coneilen@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 45640a35-85a6-4f48-a737-4892cce9b34c
…s.zig nested declarations Signed-off-by: Colin Neilens <coneilen@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 45640a35-85a6-4f48-a737-4892cce9b34c
- App.zig: parenthesize showRemoteValidation catch before negation (unary ! bound to the error union, not the unwrapped bool) - NativeForms.zig: pass &state.values (address-of) at the two production call sites for buildNodeDraft/buildEdgeDraft, matching the slice parameter type; fix reveal_id handler to use the existing WorktreeStatus.explorerParameters + explorer.exe lpFile/lpParameters ShellExecuteW pattern (already used by App.zig's revealProjectPath) instead of a nonexistent WorktreeStatus.revealCommand - WindowsRepositoryDialogs.zig: map showCloneProgress's OperationResult to CloneStatus explicitly; cast WS_* style flags to c.DWORD via @intcast to match the codebase convention - WorktreeStatus.zig: directorySize now reads size via item.dir.statFile(item.basename) since Walker.Entry has no .stat field on the pinned Zig toolchain Signed-off-by: Colin Neilens <coneilen@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 45640a35-85a6-4f48-a737-4892cce9b34c
coneilen
force-pushed
the
coneilen-microsoft-repository-settings-parity
branch
from
September 19, 2026 23:04
f237b80 to
1ed41ca
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings Windows repository ingress, Settings, and Worktree rows toward parity: worker-backed non-blocking Clone/Add-Remote sheets, immediate valid Project Settings persistence, uncapped Worktree sweep with size totals/inline reveal/dirty confirmation, and threshold-gated worktree notice chips. See ledger updates for row-by-row evidence and remaining gaps.
RED: zig test src\WindowsRepositoryDialogs.zig -> failed: configured Zig installation directory was missing
GREEN: git diff --check -> passed with no whitespace errors
REGRESSION: Tools\windows\validate.ps1 -Task windows-shell -SkipTrayLive -SkipWslRemoteE2E -> Swift build ran and failed only because _complex and ucrt modules are unavailable