Graph overview / project canvas parity polish - #385
Merged
Merged
Conversation
coneilen
added a commit
that referenced
this pull request
Sep 19, 2026
windows-shell CI (PR #385, run 35422364203) now passes the live gate assertions for the canvas Reclaim/Keep descendants added in this workstream. Signed-off-by: Colin Neilens <coneilen@microsoft.com> Session-Id: 7e128d0c-2ff3-4ad5-b417-bdf5c7e9eb27 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Colin Neilens <coneilen@microsoft.com> Session-Id: 7e128d0c-2ff3-4ad5-b417-bdf5c7e9eb27 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Colin Neilens <coneilen@microsoft.com> Session-Id: 7e128d0c-2ff3-4ad5-b417-bdf5c7e9eb27 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
The graph fixture seeds a reclaimable worktree from process start, so the canvas Reclaim/Keep descendants for that card are present as soon as the Graph fragment is queried. Extend the existing strict child-list assertion to expect and positively validate them (name, bounds, InvokePattern) instead of failing on the new descendants as unexpected children. Signed-off-by: Colin Neilens <coneilen@microsoft.com> Session-Id: 7e128d0c-2ff3-4ad5-b417-bdf5c7e9eb27 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Reclaim/Keep are emitted as siblings immediately after their owning card, not appended after the whole card block, so the prior hardcoded expected order did not match the live sibling chain. Derive the order from the live tree (matching the existing Loops/Projects pattern) and keep a set-equality check so the assertion still fails if an element goes missing or an unexpected one appears. Signed-off-by: Colin Neilens <coneilen@microsoft.com> Session-Id: 7e128d0c-2ff3-4ad5-b417-bdf5c7e9eb27 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
windows-shell CI (PR #385, run 35422364203) now passes the live gate assertions for the canvas Reclaim/Keep descendants added in this workstream. Signed-off-by: Colin Neilens <coneilen@microsoft.com> Session-Id: 7e128d0c-2ff3-4ad5-b417-bdf5c7e9eb27 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
coneilen
force-pushed
the
coneilen-microsoft-graph-overview-canvas-parity
branch
from
September 19, 2026 19:37
9a185c9 to
94a1183
Compare
coneilen
deleted the
coneilen-microsoft-graph-overview-canvas-parity
branch
September 19, 2026 20:06
coneilen
added a commit
that referenced
this pull request
Sep 19, 2026
Resolves conflicts with PR #385 (Graph canvas parity) which merged into main concurrently: App.zig's applyUiaDynamicInvoke gained both the workspace UIA-target block (this branch) and the needs-you/activity UIA-target block (main) - concatenated, both are independent additions dispatched by the same switch. App.zig's init() guard kept this branch's GRAPHCODE_ZMX-gated workspace-init fix, which is newer than main's simpler guard. GraphModel.zig's Node.created_at field was independently added by both branches with different types (this branch: optional u64 for the loop bar/right panel elapsed metric; main: non-optional i64 for the sidebar's elapsed column) - kept the optional u64 field (superset, handles the not-yet-started case) and adjusted Sidebar.zig's call site to cast, preserving both features. uia-live-gate.ps1 and AccessibilityProvider.cpp auto-merged cleanly with no manual changes needed; spot-checked for duplicate symbols, none found. Signed-off-by: Colin Neilens <coneilen@microsoft.com> Copilot-Session: d8d2ad1c-e76d-40e5-850a-21a4e72a19ac Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings Windows graph overview and project canvas rows toward parity: lane worktree actions, gesture/zoom help, clickable attention rail with oldest item, visible connector hover/plus affordance, type-colored loop stripes, dense edge-label collision avoidance, typed node edit-details editor, Reclaim/Keep UIA descendants, and macOS-aligned canvas menus (Message/Memo removed). See ledger updates for row-by-row evidence and remaining gaps.
RED: zig build test -> error: no step named 'test'
GREEN: zig test src/GraphCanvas.zig -target x86_64-windows-msvc -lc -I../.graphcode-tools/providers/winghostty/include -> All 91 tests passed
REGRESSION: zig test src/GraphContextMenu.zig -target x86_64-windows-msvc -lc -I../.graphcode-tools/providers/winghostty/include -> All 6 tests passed