Repository navigation
test(computers): the clock panel test reads the config a call left once it has seen the call - #835
Merged
Conversation
…ce it has seen the call The test's xfconf-query stand-in recorded each call before running it and wrote the panel's config in place, so a test that waited for a call and then read the config could read it truncated (JSONDecodeError, as unit (2/2) hit on #830) or as it was before the call. The stand-in now records a call, with when it began, once the call is done, and replaces the config whole. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
tst/unit/env/envs/test_computer_clock_panel.pystands in forxfconf-querywith a small script that keeps the panel's config in a JSON file. That script recorded each call before running it, and wrote the config in place (open(..., "w")thenjson.dump). A test that waited for the third call and then read the config could therefore read it:JSONDecodeError: Expecting value: line 1 column 1 (char 0), which is howunit (2/2)failed on feat(task-steps): a prompt step keeps each role's usage, with the endpoint host it called #830 (job); orThe stand-in now records a call, keeping the time the call began, only once the call is done (including the reset it's told to fail), and replaces the config whole (
os.replace). The panel under test (clock-panel) and every assertion are unchanged.Proof
test_an_unarmed_clock_…with the sameJSONDecodeErroras CI;ruff checkis clean.Test-only; no docs changes.
🤖 Generated with Claude Code


Confidence Score: 5/5
This test-only change appears safe to merge.Summary
This test-only change makes recorded calls a reliable signal that the fake panel command has finished updating its config.
No actionable issues found. Tests were not run during this review.
Reviews (1) · Last reviewed commit: "test(computers): the clock panel test re..." · Reviewed by Greptile