Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local native-disk preparation can reject a usable KVM device because the CLI
user cannot open it directly, even though Docker can. VM overlays also need
an owned host directory and reliable cleanup when container startup finishes
late or times out.
This change:
the launcher with the directory owner's UID/GID, and grants its KVM group.
and preserves state when creation or cleanup has an unknown outcome.
prepare_bundle(..., emulate=False)so callers can prepare nativeforms without enabling emulation; the default remains unchanged.
This is a generic local Docker disk change and has no HCU or model dependency.
Validation
make lintpasses.changes. Its staged driver installation, AX query and screenshot complete.
The docs should describe the native preparation option, Docker's KVM access,
and the sandbox-owned VM state directory.


Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
This PR gives each local disk VM its own writable folder and records container ownership before startup. It also adds native-only bundle preparation.
No actionable issues found.
Diagram
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Prepare disk launcher] --> B[Create sandbox-owned VM state] B --> C[Record ownership and pending start] C --> D[Start Docker container] D -->|Success| E[Clear pending start] D -->|Failure or cancellation| F[Attempt teardown] F -->|Container found and removed| G[Remove work folder] F -->|Start outcome unknown| H[Keep folder for later teardown]Reviews (1) · Last reviewed commit: "fix(local): isolate native disk state an..." · Reviewed by Greptile