Skip to content

fix(computers): a compose here tries a failed download again, and the prune test pulls its base before building - #811

Merged
earakely-scale merged 3 commits into
mainfrom
edgararakelyan/flaky-network-fetches
Nov 19, 2026
Merged

earakely-scale merged 3 commits into
mainfrom
edgararakelyan/flaky-network-fetches

Conversation

@earakely-scale

@earakely-scale earakely-scale commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

Why

Two of main's slow-tier failures in the last few days were one dropped network request each.

  • clock_desktop_test, 11-18, 01:18 UTC run. The clock desktop's compose failed at resolve: downloading https://storage.googleapis.com/chrome-for-testing-public/…/chrome-linux64.zip failed. This machine's builder (LocalBuilder.download) tries a download once. The builder VM's helper already retries its curl 5 times on any error, 1 s apart (builder_in_vm.sh).
  • prune_test, 11-18, 16:10 UTC run. The build failed with failed to resolve source metadata for mirror.gcr.io/library/python:3.12-slim@sha256:…. The registry didn't answer BuildKit's lookup of the test's digest-pinned base. CI pre-pulls the bases of the repository's Dockerfiles (mirror_base_images.py), but this test writes its Dockerfile at runtime, so that step doesn't see it.

What

  • LocalBuilder.download tries a download again after a transport or HTTP error, 5 times, 1 s apart, as the VM helper does. Each attempt writes the file afresh, and the sha256 is still checked against the one the download names.
  • prune_test's docker fixture pulls the test's base first, trying again after 10 s and 20 s, so the build finds it on this machine. Docker resolves a digest-pinned FROM from an image under that exact name.

How it was tested

  • Unit: a new test in test_computer_builder.py checks two cases. A download whose connection drops twice is tried again and completes, after two 1 s waits. One that never comes raises ResolveError naming the error, after 6 attempts.
  • prune_test on an admin VM: with its base image removed first, both tests passed in 14 s, the fixture pulling the base.

🤖 Generated with Claude Code

RetriggerView in GreptileConfidence Score: 5/5

The follow-up changes appear safe to merge.

Summary

This PR retries failed local downloads and pre-pulls the Docker base used by the prune tests.

  • Local computer builds retry failed package downloads.
  • The prune-test fixture pulls its base before building.

No new issues found in the follow-up changes.

Reviews (2) · Last reviewed commit: "test(computers): a download dropped mid-..." · Reviewed by Greptile

earakely-scale and others added 2 commits November 19, 2026 00:36
… its connection fails

A compose of the clock desktop failed on main on 11-18 (01:18 UTC run) because downloading Chrome for Testing's zip
from storage.googleapis.com failed once. The builder VM's helper already has curl retry every download 5 times, 1 s
apart; this machine's builder tried once. It now does as the helper does, writing each attempt afresh, and still
checks the sha256 of what it fetched.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… again after a failed pull

Its build failed on main on 11-18 (16:10 UTC run) when the registry didn't answer BuildKit's lookup of its
digest-pinned base mid-build. The fixture now pulls the base first, trying again after 10 s and 20 s, so the build
takes it from this machine.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@earakely-scale
earakely-scale requested a review from a team as a code owner November 19, 2026 08:36
… next attempt

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@earakely-scale
earakely-scale merged commit 7123610 into main Nov 19, 2026
35 checks passed
@earakely-scale
earakely-scale deleted the edgararakelyan/flaky-network-fetches branch November 19, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant