Repository navigation
fix(computers): a compose here tries a failed download again, and the prune test pulls its base before building - #811
Merged
Conversation
… its connection fails A compose of the clock desktop failed on main on 11-18 (01:18 UTC run) because downloading Chrome for Testing's zip from storage.googleapis.com failed once. The builder VM's helper already has curl retry every download 5 times, 1 s apart; this machine's builder tried once. It now does as the helper does, writing each attempt afresh, and still checks the sha256 of what it fetched. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… again after a failed pull Its build failed on main on 11-18 (16:10 UTC run) when the registry didn't answer BuildKit's lookup of its digest-pinned base mid-build. The fixture now pulls the base first, trying again after 10 s and 20 s, so the build takes it from this machine. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… next attempt Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two of
main's slow-tier failures in the last few days were one dropped network request each.clock_desktop_test, 11-18, 01:18 UTC run. The clock desktop's compose failed atresolve:downloading https://storage.googleapis.com/chrome-for-testing-public/…/chrome-linux64.zip failed. This machine's builder (LocalBuilder.download) tries a download once. The builder VM's helper already retries itscurl5 times on any error, 1 s apart (builder_in_vm.sh).prune_test, 11-18, 16:10 UTC run. The build failed withfailed to resolve source metadata for mirror.gcr.io/library/python:3.12-slim@sha256:…. The registry didn't answer BuildKit's lookup of the test's digest-pinned base. CI pre-pulls the bases of the repository's Dockerfiles (mirror_base_images.py), but this test writes its Dockerfile at runtime, so that step doesn't see it.What
LocalBuilder.downloadtries a download again after a transport or HTTP error, 5 times, 1 s apart, as the VM helper does. Each attempt writes the file afresh, and the sha256 is still checked against the one the download names.prune_test'sdockerfixture pulls the test's base first, trying again after 10 s and 20 s, so the build finds it on this machine. Docker resolves a digest-pinnedFROMfrom an image under that exact name.How it was tested
test_computer_builder.pychecks two cases. A download whose connection drops twice is tried again and completes, after two 1 s waits. One that never comes raisesResolveErrornaming the error, after 6 attempts.prune_teston an admin VM: with its base image removed first, both tests passed in 14 s, the fixture pulling the base.🤖 Generated with Claude Code


Confidence Score: 5/5
The follow-up changes appear safe to merge.Summary
This PR retries failed local downloads and pre-pulls the Docker base used by the prune tests.
No new issues found in the follow-up changes.
Reviews (2) · Last reviewed commit: "test(computers): a download dropped mid-..." · Reviewed by Greptile