Skip to content

test(computers): a browser recording's video may go blank at each of its tab switches, not at one alone - #810

Merged
earakely-scale merged 1 commit into
mainfrom
edgararakelyan/flaky-recording-tab-switch-frames
Nov 19, 2026
Merged

earakely-scale merged 1 commit into
mainfrom
edgararakelyan/flaky-recording-tab-switch-frames

Conversation

@earakely-scale

@earakely-scale earakely-scale commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

Why

browser_computer_test.py::test_each_context_is_recorded_alone_its_video_following_its_agent_while_agents_act_on_all_at_once failed on main twice on 11-18, in the runs of 03:26 and 17:09 UTC. Both times the buyer's video held 4 white frames:

  • 3 at its first tab switch (frames 54–56, then 61–63);
  • 1 at its second (frame 100, then 107).

The test requires that video to follow exactly two tab switches (tab A, then B, then A again). Its own comment says a switch is blank until the new tab's first frame arrives. But it allowed only 3 white frames in the whole video, so a correct recording with a blank at both switches failed.

What

The buyer's video may go blank for at most 3 frames at each tab switch, and no more often than it switches. The seller's and the default context's videos switch no tab and keep the old limit of 3 white frames. Every other assertion is unchanged.

How it was tested

The new check against both failures' frame sequences, taken from the CI logs: the white runs were [3, 1] both times, which now passes. Blanks at more places than the video switched still fail, for example [1, 1, 1] with two switches. CI runs the test itself.

🤖 Generated with Claude Code

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge.

Summary

Adjusts the browser recording test to allow brief blanks at both buyer tab switches.

  • Buyer video checks allow a short white gap at each tab switch.

No actionable issues found.

Reviews (1) · Last reviewed commit: "test(computers): a browser recording's v..." · Reviewed by Greptile

…its tab switches, not at one alone

test_each_context_is_recorded_alone_its_video_following_its_agent_while_agents_act_on_all_at_once failed on main
twice on 11-18 (runs of 03:26 and 17:09 UTC) with the buyer's video holding 4 white frames: 3 at its first tab
switch and 1 at its second. The test requires the video to follow exactly two switches, and a switch is blank
until the new tab's first frame arrives, but it allowed 3 white frames in the whole video. It now allows a blank of
at most 3 frames at each switch, and no more blanks than switches; the other videos, which switch no tab, keep
the limit of 3.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@earakely-scale
earakely-scale requested a review from a team as a code owner November 19, 2026 08:33
@earakely-scale
earakely-scale merged commit 537ae29 into main Nov 19, 2026
35 checks passed
@earakely-scale
earakely-scale deleted the edgararakelyan/flaky-recording-tab-switch-frames branch November 19, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant