Repository navigation
fix(bundle): an installed entity pulled into a plan binds its own aliases to its bundle, whatever the store holds - #800
Merged
earakely-scale merged 2 commits intoNov 19, 2026
Conversation
…ases to its bundle, whatever the store holds A reference an installed bundle's entity makes to an alias was resolved like any other: where the store held an entity of the alias's id, that one shadowed it. So registering the installed chromium into a hub that already held `page` and `ubuntu-24.04-browser` from an earlier release composed it over those, under a key no release published, and the worker built chromium itself. Such a reference now binds what its installed bundles give the alias, pulled in and written again under the alias; references the bundle itself makes keep the store-shadows-alias rule, and only they are Plan.alias_uses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…inned Greptile r1: an entry naming an alias both unpinned and pinned had both fields rewritten to the alias's entity, the pinned one keeping its version, so it read that version of the installed id instead of the store's entity. Only an unpinned reference is ever pointed at an alias's entity, so _renamed now leaves pinned fields as they are. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
earakely-scale
deleted the
edgararakelyan/fd-6309-an-installed-entity-pulled-into-a
branch
November 19, 2026 03:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When the bundle planner pulls in an entity from an installed bundle, that entity's own references to aliases now bind what its installed bundles give those aliases, even where the store holds an entity of the alias's id. Those targets are pulled in too and written again under the alias. References a bundle makes itself keep #733's rule, where the store's entity shadows the alias.
_Planner._pointed: for an entry inorigins(pulled from an installed bundle), a store reference to an alias points at the alias's installed target (_installed_alias, a direct alias-table lookup), whatever the store holds. A refused alias, or a reference pinning a version, falls back to_alias_ofas before._renamedrewrites only unpinned fields naming a pointed alias (Greptile r1). Only an unpinned reference is ever pointed, so a pinned field naming the same alias keeps naming the store's entity.Plan.alias_uses. That map lists the aliases the bundle itself names, andbundle runreports it as such. Recording them would report "the store's env 'page' v1, which shadows the alias" for a reference that was in fact bound to the installed one.Why
Chromium's 0.9.1574 dev promotion on AgentEnvHub registered the installed chromium by its own id (agentenvhub-sdk 0.42.2). Its references to its driver and base computer (
page,ubuntu-24.04-browser, both aliases) bound to the hub's copies from the 0.9.1558 promotion, so chromium v2 was composed over them. That closure's composition key (1e8fcaf9…) isn't the release's (102edd82…). So the worker composed chromium itself (amd64 only) into the hub's registry instead of reusing the released image. The promotion's gate passed, but on that image, and the promotion then reported failed, because its index digest isn't the release's.Registering an installed entity means its closure as installed. Its references bind to that closure the same way whether the store is empty, which is why the first promotion worked, or already holds older copies.
Tests
test_the_installed_chromium_registers_over_its_own_driver_though_the_store_holds_another_under_the_alias. It registers the installed chromium into a shared store, edits the store'spage, and registers again. The installedpageis written again (v3) and chromium points at it. Without the fix it fails withKeyError: 'page', the same failure as on the hub.test_pointing_an_alias_rewrites_only_the_fields_naming_it_unpinned._renamedrewrites only unpinned fields, so a pinned field keeps naming the store's entity, as its reference does (Greptile r1).tst/unit/bundle/: 1293 passed before the new test, andtst/unit/bundle/,tst/unit/store/,tst/unit/env/together: 5229 passed with the change. One failure,test_disk_recipe.py::test_a_windows_install…, fails the same way on main on macOS and is unrelated.FD-6309
🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge.Summary
Installed entities pulled into a bundle plan now keep their installed alias targets, even when the store holds another entity under that alias.
No new actionable issues found.
Reviews (5) · Last reviewed commit: "fix(bundle): pointing an alias rewrites ..." · Reviewed by Greptile