Repository navigation
feat(env): give each computer in a multi env a control token of its own - #796
Closed
andrewpark-scaleai wants to merge 1 commit into
Closed
andrewpark-scaleai wants to merge 1 commit into
andrewpark-scaleai wants to merge 1 commit into
Conversation
andrewpark-scaleai
force-pushed
the
andrewpark/vuln-3253-sidecars-behind-gateway
branch
from
November 18, 2026 23:54
9459d49 to
7985a79
Compare
andrewpark-scaleai
force-pushed
the
andrewpark/vuln-3253-computer-tokens
branch
from
November 19, 2026 00:39
852bdba to
e94f88c
Compare
andrewpark-scaleai
marked this pull request as ready for review
November 19, 2026 18:21
Comment on lines
+110
to
+112
| @pytest.mark.asyncio | ||
| @pytest.mark.parametrize("path", sorted(OPEN)) | ||
| async def test_a_gateway_started_without_a_token_lets_a_childs_through_nowhere_but_the_child(path): |
There was a problem hiding this comment.
Route cases repeat one request. This test takes
path from OPEN, but every case requests /echo. All 12 cases check the same route, so the listed routes add no coverage and failures get misleading case names. Remove the unused parameter if /echo is the intended check, or make each case exercise its named route.
Prompt To Fix With AI
This is a comment left during a code review.
Path: tst/unit/env/gateway/control_token_test.py
Line: 110-112
Comment:
**Route cases repeat one request.** This test takes `path` from `OPEN`, but every case requests `/echo`. All 12 cases check the same route, so the listed routes add no coverage and failures get misleading case names. Remove the unused parameter if `/echo` is the intended check, or make each case exercise its named route.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Each computer mints its own control token at deploy. The gateway receives them in CHILD_CONTROL_TOKENS and sends each computer's token on that computer's /svc routes. A driver whose card advertises control_token "sha256" boots with only the token's digest (AGENTENV_CONTROL_TOKEN_SHA256). granted_headers picks the longest matching grant. CONTROL_TOKEN_CHILDREN stays for computers an older agent-env booted.
andrewpark-scaleai
force-pushed
the
andrewpark/vuln-3253-computer-tokens
branch
from
November 19, 2026 18:48
afb8fad to
e3c6e38
Compare
andrewpark-scaleai
force-pushed
the
andrewpark/vuln-3253-sidecars-behind-gateway
branch
from
November 19, 2026 18:48
7985a79 to
5d14668
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A multi env's computers shared the gateway's control token. This PR gives each computer a token of its own, so each credential opens only what it is for, and keeps the token out of the computer session's process environment.
What changed
CHILD_CONTROL_TOKENSand sends each computer's token on that computer's/svcroutes.AGENTENV_CONTROL_TOKEN_SHA256, and the driver card advertisescontrol_token: "sha256".granted_headerspicks the longest matching grant prefix.Scope
CONTROL_TOKEN_CHILDRENstays in the gateway for computers an older agent-env booted. Delete it once no deploy sets it.Blast Radius
CONTROL_TOKEN_CHILDREN.child_envs[<name>].control_tokenof the multi env's record. A hub that strips the top-level token from reads should strip these too.Verification
tst/unit/env,tst/unit/providers,tst/unit/task,tst/unit/task_step,tst/unit/driversand the protocol's tests pass, except environment-specific failures that also fail on the base branch.multi_env_computers_test.pyasserts each computer holds its own token.

Confidence Score: 5/5
The PR appears safe to merge; the remaining test-coverage issue is non-blocking.Fix with agent prompt
Summary
Each computer now gets its own control token. Compatible drivers boot with only its hash, while the gateway forwards the right token to each computer.
No new actionable issues were found.
Diagram
%%{init: {'theme': 'neutral'}}%% flowchart LR F[Framework] -->|Gateway token| G[Gateway] F -->|Computer token on its route| G G -->|Computer A token| A[Computer A] G -->|Computer B token| B[Computer B] A --- HA[Stores token hash when supported] B --- HB[Stores token hash when supported]Reviews (2) · Last reviewed commit: "feat(env): give each computer in a multi..." · Reviewed by Greptile