Repository navigation
fix(computer): the probe's recording-limit check holds on a computer already recording - #782
Merged
earakely-scale merged 4 commits intoNov 18, 2026
Conversation
…already recording The full probe's limit check started max_concurrent recordings, catching nothing, and expected only the next to be refused. On a computer recording already, as a task's that records while it probes, the loop's own second start was refused (limit_exceeded) and the check failed, though the limit held. The probe can't count recordings it didn't start, so a limit_exceeded refusal at any of its starts now holds the limit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…so an early refusal still fails A refusal at any start passed the limit check, so a driver that refused short of its declared max_concurrent passed even on an idle computer, which the check caught before. computer-recording/v1 now has a list op, served by the SDK's recordings, naming those still recording. The probe starts only what's left of the limit beside the recordings a driver lists, and from a driver that doesn't list them starts the whole limit, as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…sted around it The limit check counted the other recordings once, so one that ended before the probe's last start made that start succeed and read as a violation, and one that started meanwhile made an earlier start refused. Each start is now judged by a listing before it, and an unexpected outcome by a listing after it: a refusal fails only while fewer than max_concurrent are recording, and a start past the limit only once more than max_concurrent are. The path for a driver that doesn't list its recordings is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tries, and one card helper in its tests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
earakely-scale
deleted the
edgararakelyan/fd-6254-conformance-probe-the-recording-limit
branch
November 18, 2026 19:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The full probe's check
X a recording past max_concurrent is refusedno longer fails on a computer that's already recording, and it still fails every driver it failed before.limited()startedmax_concurrentrecordings, then expected the next start to be refused. A recording the probe didn't start, as when a task records the screen while it probes, counts against the limit too (Recordings.start). So the loop's own second start was refused withlimit_exceeded, and the check failed though the limit held.computer-recording/v1has alistop (GET), which returns{recordings}, each still recording as{recording_id, started_at}. It's served by the SDK's sharedRecordings(listed()), so every SDK driver has it. Like every framework-only route, it takes the env's control token.list, the probe lists the open recordings before each start. Belowmax_concurrentthe start must succeed; at it, the start must be refusedlimit_exceeded. Other recordings may start or end meanwhile, so an unexpected outcome is checked against a listing right after:max_concurrentare still recording.max_concurrentare recording.LIMIT_STARTS(3) starts per slot, then reports that the computer's recordings kept changing.listis checked exactly as before: the probe starts the wholemax_concurrent. On a computer already recording, that driver still fails the check, as today.So nothing the check caught before passes now:
The probe still ends only the recordings it started, so a task's own stays running.
The protocol README documents
listand the probe's counting.FD-6254, under FD-6253.
Not here:
max_concurrent: the probe's first recording check can't start one there, so it and the repeated-request_idcheck fail. That's as before, and outside FD-6254.env/envs/playwright_mcp/recorder.py) serves the extension'sstartandendbut nolist. It isn't a computer driver the probe checks.Proof
test_computer_conformance_recording.py,test_computer_recording.py):main.listpasses idle and fails while recording, as onmain.recording 3 of at most 2 started, the other an earlylimit_exceeded.listnames each recording still recording, as its start answered it, and none once ended. Without the control token it's refused 401.start,end,end_allandlist.tst/unit/envandtst/unit/task_stepgave 7,770 passed, 4 skipped, on the version before the race fix. The protocol package alone, on the final version: 1,663 passed, 1 skipped. Two failed in the larger run:test_disk_recipe.py::test_a_windows_install_boots_its_iso_first_..., which fails onmainon this Mac too.process_scope_socket_test.py::test_an_armed_time_trigger_keeps_firing_after_a_client_leaves. It passed 3 of 3 runs on its own, and this PR touches no gateway code.desktopexample with the issue's task (deploy,start_computer_recording, the probe asenv_outcome_verifier,end_computer_recording).scored below 1 (probe: 0).passed (probe: 1). The composed driver servedlist: without it the probe starts the whole limit, which fails on a computer recording already.probetask, which doesn't record:passed (probe: 1).🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge; no blocking issues were found.Summary
The probe counts recordings already running when it checks the recording limit, without ending recordings owned by the task.
The latest changes preserve behavior. The earlier finding about ended recordings is addressed. No new issues were found.
Reviews (8) · Last reviewed commit: "refactor(computer): plainer limit-check ..." · Reviewed by Greptile