Skip to content

test(computer): the display-only reuse test checks what was reused, not how long the put took - #779

Closed
earakely-scale wants to merge 1 commit into
mainfrom
edgararakelyan/computer-reuse-test-no-timing-bound
Closed

earakely-scale wants to merge 1 commit into
mainfrom
edgararakelyan/computer-reuse-test-no-timing-bound

Conversation

@earakely-scale

@earakely-scale earakely-scale commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

What

tst/integration/computer/computer_env_test.py::test_an_env_that_changes_only_its_display_and_name_reuses_the_image failed integration-local-slow (8/12) on #761 with assert 85.58 < 60, unrelated to that PR.

The test bounded the whole ComputerEnv.put at 60 s. A put that reuses the image still boots it and probes it to mark it ready (the test asserts status == "ready"), so the bound measures a boot and a probe on a shared runner, not reuse. Reuse is what the test's other checks assert directly: reused is True, the same image, the same installed packages, not emulated. The timing bound is dropped; those checks stay.

Verified

  • The slow shard's log (job 134998510594): the test's own assertions passed up to assert took < 60; it measured 85.6 s.
  • None of the other failed Local backends runs among the last 60 failed on this test.
  • ruff check and collection pass; the test itself runs in the slow tier, which this PR's CI runs.

🤖 Generated with Claude Code

RetriggerView in GreptileConfidence Score: 5/5

This test-only change appears safe to merge.

Summary

Removes the reuse test’s 60-second limit while keeping its direct checks that the image was reused and the computer became ready.

  • The image-reuse test no longer limits full startup to 60 seconds.

No actionable issues found.

Reviews (1) · Last reviewed commit: "test(computer): the display-only reuse t..." · Reviewed by Greptile

…ot how long the put took

The test also bounded ComputerEnv.put at 60 s, which reuses the image but still boots and probes it to mark it ready;
on a busy runner that took 85 s (one slow shard on #761). Reuse itself is what its other checks assert: the same image,
the same installed packages, reused and not emulated.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@earakely-scale
earakely-scale requested a review from a team as a code owner November 18, 2026 17:45
@earakely-scale

Copy link
Copy Markdown
Collaborator Author

Folded into #761 as b7f605f, since #761's CI is where this flake showed up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant