Repository navigation
test(computer): the display-only reuse test checks what was reused, not how long the put took - #779
Closed
earakely-scale wants to merge 1 commit into
Closed
earakely-scale wants to merge 1 commit into
earakely-scale wants to merge 1 commit into
Conversation
…ot how long the put took The test also bounded ComputerEnv.put at 60 s, which reuses the image but still boots and probes it to mark it ready; on a busy runner that took 85 s (one slow shard on #761). Reuse itself is what its other checks assert: the same image, the same installed packages, reused and not emulated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
tst/integration/computer/computer_env_test.py::test_an_env_that_changes_only_its_display_and_name_reuses_the_imagefailedintegration-local-slow (8/12)on #761 withassert 85.58 < 60, unrelated to that PR.The test bounded the whole
ComputerEnv.putat 60 s. A put that reuses the image still boots it and probes it to mark itready(the test assertsstatus == "ready"), so the bound measures a boot and a probe on a shared runner, not reuse. Reuse is what the test's other checks assert directly:reused is True, the same image, the same installed packages, not emulated. The timing bound is dropped; those checks stay.Verified
assert took < 60; it measured 85.6 s.Local backendsruns among the last 60 failed on this test.ruff checkand collection pass; the test itself runs in the slow tier, which this PR's CI runs.🤖 Generated with Claude Code


Confidence Score: 5/5
This test-only change appears safe to merge.Summary
Removes the reuse test’s 60-second limit while keeping its direct checks that the image was reused and the computer became ready.
No actionable issues found.
Reviews (1) · Last reviewed commit: "test(computer): the display-only reuse t..." · Reviewed by Greptile