Repository navigation
fix(gateway): list a site that declares no names at its .localhost name, as a browser computer opens it - #777
Merged
earakely-scale merged 4 commits intoNov 18, 2026
Conversation
…ts .localhost name, as a browser computer opens it A multi env whose website browser is a computer lists its sites by name, since the browser can't reach their containers. A site declaring no names was listed at its backend address, which the browser can't resolve, while the computer's site proxy routes it at fallback_name(site) and its start tabs open it there. The gateway now lists that name too; a site whose card can't be read yet keeps its address until it can. fallback_name moves next to listed_url so the gateway and the site proxy share one rule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ts card gives it, as the site proxy routes it The site proxy names a site by its website/v1 card's name, unless two of the env's cards give one name, and then each by the name it's served as; a site declaring no names is routed at fallback_name of that. The gateway now keeps each card's name (SiteCard.name, website_card_name) and lists the sites by the same rule (served_names, shared with sites._served_names), instead of by the name each is served as. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… sites' only when a fallback is needed Greptile r2: reading every listed site's card one after another made a stalled card endpoint delay the whole list, even when every site stores its names. Cards of sites without stored names are now read at once, and those of sites with stored names only when some site needs a fallback, the one case their names can change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tnames a site is reached at Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
earakely-scale
deleted the
edgararakelyan/fd-6251-list_website_urls-gives-a-site
branch
November 18, 2026 19:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A multi env whose website browser is a computer (
browser_envs = ["chromium"]) lists its sites by name inlist_website_urls, because the browser runs on a sandbox of its own and can't reach the sites' containers. A site that declares no names, with nodomainsand none on its card, was listed at its backend address, e.g.http://gate-website-website-frontend/, which the browser can't resolve.The computer's site proxy already routes such a site at
fallback_name(site)(<site>.localhost), and its start tabs open it there. Now the gateway lists that name too, so an agent that opens a site fromlist_website_urlslands on it.Gateway._listed_urls: a site listed by name whose stored names and card both declare none is listed atfallback_nameof the name it goes by, as the site proxy names it. That's itswebsite/v1card's name, unless two of the env's cards give one name, and then each site goes by the name it's served as. A site whose card can't be read yet keeps its address, as before, until the card can be read, so a site that would declare names isn't listed at the wrong one.fallback_namemoves fromcomputer/utils/sites.pytogateway/rest_proxy.py, next tolisted_url, beside the newserved_names(whichsites._served_namesnow calls) andwebsite_card_name(which the gateway'sSiteCardkeeps ascard_name, besidenames, the hostnames).sites.pyimports them from there; the gateway package keeps importing only its own modules.Why
Chromium's first dev promotion on AgentEnvHub failed its
browser_pagecheck on modal_vm. Its browser recording shows the start tab loadinghttp://gate-website.localhost/(200), then the probe navigating to the addresslist_website_urlsgave,http://gate-website-website-frontend/, and failing. M8.13's integration test covers only sites with stored or card names, so the nameless case wasn't exercised.Tests
test_list_website_urls_gives_a_site_listed_by_name_at_its_first_name_and_any_other_behind_the_gateway:barenow expectshttp://bare.localhost/, andOld_Notesexpectshttp://old-notes.localhost/(same lowercase and_rule as the site proxy). It fails on main.test_list_website_urls_gives_a_site_listed_by_name_its_address_while_its_card_cant_be_read.test_a_site_declaring_no_names_is_listed_at_the_fallback_of_the_name_its_card_gives_it_as_a_proxy_routes_it.noteswith the cardNotesAppis listed athttp://notesapp.localhost/, and two cards both namedShopsend every site to its served name (Greptile r1).test_list_website_urls_reads_no_card_when_every_site_listed_by_name_stores_its_names. Cards are read at once, and those of sites with stored names only when some site needs a fallback (Greptile r2).tst/unit/env/gateway/rest_proxy_stream_test.py,tst/unit/env/envs/test_computer_sites.py,tst/unit/env/envs/test_multi_env_computers.py: 1309 passed locally (tst/unit/env/gateway/plus the two site test files).The live check is chromium's next dev promotion. It passes
browser_pageonce dev's gateway serves the release with this fix.🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge; no new blocking issues were found.Summary
The gateway now lists nameless websites at the same
.localhostaddresses used by the browser’s site proxy. The latest update renamesSiteCard.nametocard_namewithout changing behavior..localhostaddress.Reviews (8) · Last reviewed commit: "refactor(gateway): SiteCard.card_name, s..." · Reviewed by Greptile