Repository navigation
test(computer): load files into a multi env's computer as an environment named after it - #767
Merged
Merged
Conversation
…ugh its driver Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…er by name Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
williamloo-scale
force-pushed
the
wloo/computer-exec-step
branch
from
November 19, 2026 00:11
c1759be to
3d3ffd8
Compare
williamloo-scale
force-pushed
the
wloo/load-artifact-computer
branch
from
November 19, 2026 00:11
80bce75 to
04e634f
Compare
Contributor
Author
|
@greptileai review |
Resolve the conflicts with the squash-merged #749: main's computer_exec and AGENTS.md, with this PR's computer_of split, computer_problem and its AGENTS.md text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A multi env already loads an environment artifact named after one of its computers into that computer, its files at their paths under the session user's home, so load_artifact needs no computer of its own. The end-to-end test loads the download setup's files that way, with plain env_id; load_artifact, ComputerEnv and computer_exec are main's again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second PR of a stack that replaces
osworld_initializewith native agent-env steps. #749 (computer_exec) is merged.OSWorld's
downloadsetup puts files on the computer before the agent starts, at paths under the home (452 of the 458 files OSWorld's tasks download are under/home/user/; the other 6 are relative). On a multi env (computers beside websites, as CUA-gym tasks have), this needs no new step field. A multi env already sends an environment artifact to the child of itsenvironment_name. When that name is one of its computers, the files are written at their paths under the computer's session user's home, through its driver'sdata/add, in the shapesnapshot_computer_envexports.So an imported task's download files are an environment artifact named after the task's computer, keyed by their paths under the home, loaded with a plain
load_artifacton the multi env:{"id": "files", "type": "load_artifact", "env_id": "office", "artifact_id": "desk_files"}With several computers, each gets its own environment artifact, by its name, in one environment universe.
What it does
tst/integration/computer/computer_files_test.py, run byagent-env run:ubuntu-24.04computer with the reference driver;computer_exec.computer_execin the background exits 127 for a program that isn't there.An earlier version of this PR added a
computerfield toload_artifact, with aload_fileshelper andcomputer_of. Review found that the multi env's existing routing by environment name already covers this, so those changes are gone.load_artifact,ComputerEnvandcomputer_execare unchanged from main.Testing
On an Ubuntu 24.04 VM (c6i.4xlarge):
tst/integration/computer/computer_files_test.pypasses (115 s).tst/unit/task_step,tst/unit/env/envs/test_multi_env_computers.pyandtst/unit/env/envs/test_computer_env.py: 4,242 pass.test_mcp_cli_builder.pyfail there, and fail the same way on main: the CLI they generate runs under the VM's system Python, which has nohttpx.The stack
computer_exec(merged).init_configinstead ofosworld_initialize. Itsdownloadsetup becomes an environment artifact named after the task's computer.The rubric-judge verifier (
cua_verifier) is a separate stack.🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge; no blocking issues were found.Summary
The PR now adds an integration test for loading files into a multi-environment computer through an environment artifact named after that computer. Runtime code is unchanged from the base branch.
deskand reads them.Reviews (6) · Last reviewed commit: "Load a multi env's computer's files as a..." · Reviewed by Greptile