Repository navigation
fix(bundle): bundle init pins a pulled image to the digest its store records - #764
Open
earakely-scale wants to merge 2 commits into
Open
earakely-scale wants to merge 2 commits into
earakely-scale wants to merge 2 commits into
Conversation
…records
An image bundle init writes as a registry ref (one with no context the folder can hold) was written as its
image_name alone, so an image stored by digest, as bundle register stores a `{ ref = "<repo>@sha256:..." }`
image, went into the folder as its bare repository: a run would pull whatever that repository's latest is. It's
written as its pinned_name now, the name a sandbox pulls.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A ref giving a tag beside its digest is refused once the tag moves, so the bundle's first run would stop before deploying an image its registry still serves by digest. A computer base named from a registry is written the same way. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
bundle initwrites some images as registry refs: one whose store holds no build context, or one whose context the folder can't hold. It wroteartifact.image_namealone. An image stored by digest, asbundle registerstores{ ref = "<repo>@sha256:…" }, therefore went into the folder as its bare repository, and a run would pull whatever that repository's latest is.Both places now write the image by its digest alone,
<repo>@sha256:…(registry_api.by_digestofartifact.pinned_name), whether the digest is recorded beside the name or inside it. A tag is left out becausepin_digestrefusesname:tag@digestonce the tag moves, which would stop the bundle's first run although the registry still serves the image by digest. An image with no digest is written as before. A computer base named from a registry goes through the same path, so it's written by digest too.Why
I found it exporting the laptop task's computer version from the dev hub (HB5.1.1, FD-6206). Its Shelfway frontend's context couldn't be written: its Dockerfile
COPY . .includes the folder's ownenv.toml. The fallback ref came out as…/shelfway-frontendwith no digest.Proof
importer_entities_test.py, one per branch:ref = "<repo>@sha256:…", for a tagged name with the digest beside it and inside it, and both failwithout the fix.
registry_api_test.py:by_digestdrops a tag beside a digest, and a ref by digest alone stillpins once its tag has moved, where
name:tag@digestis refused.computer_to_toml_edges_test.py: a registry-named base now reads back asdesk@sha256:…, the digest the storeholds.
tst/unit/bundle,tst/unit/store,tst/unit/artifactand the protocol tests: 4,481 pass. One fails,version_lookup_benchmark_test.py, which needs a git checkout and the copy had none.ruff check: clean.🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge; the moved-tag failure is fixed.Summary
bundle initnow keeps stored image digests in registry references and removes adjacent tags so later tag changes do not break the exported bundle.Reviews (2) · Last reviewed commit: "fix(bundle): a pulled image is written b..." · Reviewed by Greptile