Skip to content

fix(bundle): register writes a universe folder under its registry id - #762

Merged
earakely-scale merged 1 commit into
mainfrom
edgararakelyan/register-universe-folder-registry-ids
Nov 19, 2026
Merged

earakely-scale merged 1 commit into
mainfrom
edgararakelyan/register-universe-folder-registry-ids

Conversation

@earakely-scale

@earakely-scale earakely-scale commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

What

bundle register refused every bundle that holds an environment universe folder (artifacts/<name>/ with type = "environment_universe" and a folder per environment).

read_folder names each environment as <universe>__<name> and each environment's file as …__file. It checked every one of those ids with validate_local_id. Under register, the universe's id is a registry id, which never starts with @local/, so:

  1. _child_id treated every name as invalid and hashed it (<universe>__sha256__…);
  2. the hashed id was then refused: can't name the artifacts written from it (local id '…' must start with '@local/' or '@hf/'); give the universe a shorter name.

No shorter name could help.

Now a local id is checked as one, and a registry id takes the folder's names as they are. This matches how the recording step treats ids (if is_local_id(id): validate_local_id(id)). agent-env run, where ids are local, is unchanged.

Why

I hit it while registering the laptop task's computer version into AgentEnvHub's dev stage (HB5.1.1, FD-6206). Its universe is the tools version's own -u folder.

Proof

  • New tests:
    • environment_universe_folder_test.py: a universe read under a registry id names gmail <id>__gmail and its file <id>__gmail__file. A name holding __ is still hashed.
    • register_test.py: a bundle whose task loads a universe folder registers. Its environments are triage-world-u__gmail and triage-world-u__shelfway.
  • Both tests fail without the fix, with the same error the CLI gave.
  • Test files: tst/unit/artifact/environment_universe_folder_test.py and tst/unit/bundle/register_test.py, 39 passed.
  • ruff check: clean.
  • Live: with this change, agent-env --stage dev bundle register wrote the laptop task's universe into the dev stores. Without it, the registration failed at the universe.

🤖 Generated with Claude Code

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge.

Summary

Fixes bundle register for environment universe folders by applying local ID checks only to local IDs.

  • Registered universes keep ordinary environment names under their registry id.

No actionable issues found.

Reviews (1) · Last reviewed commit: "fix(bundle): register writes a universe ..." · Reviewed by Greptile

bundle register refused any bundle holding an environment universe folder: the folder's environments and their
files are named from the universe's id, and every one was checked as a local id, which a registry id never is, so
each name was first hashed and then refused as "must start with '@local/'", with advice to shorten the name that
couldn't help. A local id is still checked as one; a registry id takes the folder's names as they are.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@earakely-scale
earakely-scale requested a review from a team as a code owner November 18, 2026 04:24
@earakely-scale
earakely-scale merged commit 3fdb538 into main Nov 19, 2026
35 checks passed
@earakely-scale
earakely-scale deleted the edgararakelyan/register-universe-folder-registry-ids branch November 19, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant