Repository navigation
test(computers): the base desktop tests wait for the window manager before checking it - #760
Merged
Merged
Conversation
…efore checking it supervisord has the desktop RUNNING as its process starts (startsecs=0). That process then waits for X and starts the XFCE session, which starts xfwm4, so the root window's WM check read right after could find none yet: _NET_SUPPORTING_WM_CHECK: not found. It failed main at c9472ae, which only bumps the version, after the same code passed at ea8e6f1. Both tests that read it now wait up to 60 s for xfwm4 to set it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
earakely-scale
marked this pull request as ready for review
November 18, 2026 03:21
…erval Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two base computer tests now wait for the window manager before checking it:
test_the_desktop_runs_as_the_session_user_with_the_settings_a_deploy_passestest_the_desktop_comes_back_however_often_x_diesEach read the root window's
_NET_SUPPORTING_WM_CHECKonce supervisord had every program RUNNING. But the base'sprogram:desktophasstartsecs=0, so supervisord has it RUNNING as soon as its process starts. That process,start-desktop with-x xfce4-session, then waits up to 10 s for X to answer and starts the XFCE session, which starts xfwm4. Read in between, the check finds no window manager:_NET_SUPPORTING_WM_CHECK: not found.The second test waited a fixed 5 s, which has the same race.Both now read it through
_window_manager, which waits up to 60 s for xfwm4 to set it, as_all_runningwaits for supervisord. Nothing else changes: the tests assert the same things.Why
It's a race in the test, and it has turned
mainred:mainfailed atc9472ae1, which only bumps the version, inintegration-local-slow (10/12). The same code passed atea8e6f1djust before.Both failures read
dimensions: 1600x900 pixels, the right screen, and_NET_SUPPORTING_WM_CHECK: not found.Proof
On an agent-environments-admin VM (amd64), with the published base this branch's sources name:
The race, measured. A probe booted the base 5 times. Each time, it polled supervisord until every program was RUNNING, then polled the root window's WM check:
So the window is real even on an idle machine, and a loaded CI runner widens it.
The two tests with this change: 3 of 3 runs passed, 2 passed each time (31–33 s).
ruff check tstpasses.🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge; no blocking issues were found.Summary
The desktop integration tests wait for the window manager before checking it.
Reviews (2) · Last reviewed commit: "test(computers): name the window manager..." · Reviewed by Greptile