Repository navigation
refactor(env): reach pgweb and db-mcp only through the gateway's /svc routes - #752
Closed
andrewpark-scaleai wants to merge 1 commit into
Conversation
andrewpark-scaleai
force-pushed
the
andrewpark/vuln-3253-close-console-tunnels
branch
from
November 17, 2026 23:56
d462b3c to
a6e6d1b
Compare
This was referenced Nov 17, 2026
andrewpark-scaleai
force-pushed
the
andrewpark/vuln-3253-sidecars-behind-gateway
branch
from
November 18, 2026 23:54
9459d49 to
7985a79
Compare
andrewpark-scaleai
force-pushed
the
andrewpark/vuln-3253-close-console-tunnels
branch
from
November 18, 2026 23:55
a6e6d1b to
67eadaa
Compare
andrewpark-scaleai
marked this pull request as ready for review
November 19, 2026 18:21
… routes The VM path exposes only the gateway's port, the compose file publishes no port for pgweb or db-mcp, and the container path creates their sandboxes with expose_externally=False. DeployedGateway drops db_web_url and db_mcp_url, so new records name the consoles only at db_web_gateway_url and db_mcp_gateway_url. DeployedGatewayEnv still reads both from older records for one release.
andrewpark-scaleai
force-pushed
the
andrewpark/vuln-3253-close-console-tunnels
branch
from
November 19, 2026 18:48
67eadaa to
fc74893
Compare
andrewpark-scaleai
force-pushed
the
andrewpark/vuln-3253-sidecars-behind-gateway
branch
from
November 19, 2026 18:48
7985a79 to
5d14668
Compare
andrewpark-scaleai
deleted the
andrewpark/vuln-3253-close-console-tunnels
branch
November 19, 2026 18:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After #751, the gateway serves pgweb and db-mcp at
/svc/. This PR makes that the only way in, so deploys expose one port (the gateway's) and records carry one set of console URLs.What changed
env-networkstill reach them.expose_externally=False, as it already does for other sidecars.DeployedGatewaydropsdb_web_urlanddb_mcp_url, so no deploy writes them.DeployedGatewayEnvstill reads them from older records for one release.Blast Radius
db_web_urlordb_mcp_urlgets None on a new deploy's record. Every one must move todb_web_gateway_url/db_mcp_gateway_urlfirst.Verification
create_vmgets only the gateway and sidecar ports.tst/unit/env/test_env.pyloads a record from an older deploy.tst/unit/env,tst/unit/providersandtst/unit/clipass.ruff check src tstpasses.modal_vm: the consoles answer through the gateway with the token.

Confidence Score: 5/5
The code appears safe to merge once the stated rollout requirements are met.Summary
This PR makes the gateway the only public route to pgweb and db-mcp while keeping older deployment records readable.
andrewpark-scaleaiexplicitly defers merging until all consumers use the gateway URLs and the gateway image from #751 is promoted. They also acknowledge losing OpenClaw’s database link because its owner confirmed nobody uses it. These are stated rollout requirements and accepted behavior, not new findings.Reviews (2) · Last reviewed commit: "refactor(env): reach pgweb and db-mcp on..." · Reviewed by Greptile