Skip to content

feat(bundle): register writes an installed env or artifact under its alias, into a shared store - #744

Merged
earakely-scale merged 1 commit into
mainfrom
edgararakelyan/fd-5908-register-installed-aliases
Nov 18, 2026
Merged

earakely-scale merged 1 commit into
mainfrom
edgararakelyan/fd-5908-register-installed-aliases

Conversation

@earakely-scale

@earakely-scale earakely-scale commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

What and why

M8.60 (FD-5908), PR 2 decision 1: chromium reaches the hub through bundle register.

For promotion to put chromium on the hub, registering a task that names chromium has to write chromium and the three entities it needs under the ids the hub's tasks name them by. A plan of that task writes four installed-bundle entities, each with an alias equal to its folder name:

Entity Kind Registers as
@local/agentenv-framework/browsers/chromium env, computer_app chromium
@local/agentenv-framework/drivers/page env, computer_driver page
@local/agentenv-framework/computers/ubuntu-24.04-browser artifact, computer ubuntu-24.04-browser
…/ubuntu-24.04-browser__forms_container_image its container image ubuntu-24.04-browser__forms_container_image, as published

Register gave an installed bundle's agent its alias, and refused any other installed entity ("only an agent with an alias is registered from one").

What changes

  • bundle/register.py:
    • An installed bundle's env or artifact that a reference pulls in takes its first alias as its registry id, as an installed agent already does. Its derived ids keep their suffix after it.
    • Before anything is written, a registration into this machine's own store refuses an installed env, since that store would refuse its alias's id. The message says to register into a shared store instead.
  • env/store.py: put_document refuses a new env under an installed alias's id only in this machine's own store, where its runs record deployments under an alias, and no longer only when namespace routing is on (feat(env): the env store refuses an alias's id only where aliases resolve, so a service may hold one #733). A shared store such as the hub's may hold chromium, whoever writes it: a service, or a registration with routing on.
  • store/routing.py: shared_store moves here from register, next to configured_store, and now looks through a routing store to its configured side. Register and the env store both use it.
  • AGENTS.md: the store rule and bundle register's ids.

The store's env of an id still wins over the alias wherever that store is read, and the one-time catch is documented as before: alias deployments recorded in that store before chromium was written.

PR 2 (scaleapi) then registers chromium into the hub during promotion, gated in place as agents are (decision 2).

How it was tested

  • tst/unit/bundle/register_test.py:
    • Registering a task that names chromium into a shared store writes chromium, page, ubuntu-24.04-browser and its image under those ids, plus the task. The task's step pins chromium v1, and the stored chromium names ubuntu-24.04-browser and page.
    • The same registration into this machine's own store is refused before anything is written, with the new message.
  • tst/unit/env/alias_get_test.py:
    • A shared store holds an env under an alias's id, and a task naming the alias gets it, with routing off and with routing on.
    • This machine's own store refuses the alias's id with routing off too.
  • These new tests fail or error on main.
  • tst/unit/env, store, bundle, a2a_agent, cli, plugins_test.py: 5922 passed. The one failure is the Windows disk recipe's exit code, which fails on main on macOS too.

🤖 Generated with Claude Code

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no actionable issues were found.

Summary

Allows installed envs and artifacts pulled into a registration to use their first alias as their registry ID.

  • Installed envs and artifacts register under their declared aliases.
  • Alias envs are allowed in shared stores but blocked in this machine’s store.

Acknowledgment: earakely-scale explicitly states that stored envs shadow installed aliases, including the effect on deployments recorded before registration. This behavior was not reported as a defect.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Plan selected bundle entries] --> B[Give installed entries their alias IDs]
  B --> C{Target store}
  C -->|Local, with installed envs| D[Refuse before writing]
  C -->|Shared| E[Rewrite references and derived IDs]
  E --> F[Write versions through the target ledger]
Loading

Reviews (1) · Last reviewed commit: "feat(bundle): register writes an install..." · Reviewed by Greptile

…alias, into a shared store

For promotion to put chromium on the hub, registering a task that names `chromium` has to write chromium, its
page driver and its base computer under the ids the hub's tasks name them by. Register gave an installed
bundle's agent its alias and refused any other installed entity. It now gives an installed env or artifact its
alias too, so chromium registers as `chromium`, with `page`, `ubuntu-24.04-browser` and its image.

The env store's refusal of an alias's id moves from namespace routing being on to the store being this
machine's own, where its runs record deployments under an alias. A shared store such as the hub's may hold
`chromium`, whoever writes it, and register checks before writing anything that an installed env goes only into
a shared store. `shared_store` moves from register to `store.routing`, where both use it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@earakely-scale
earakely-scale requested a review from a team as a code owner November 17, 2026 19:17
@earakely-scale
earakely-scale merged commit 0ee2ac1 into main Nov 18, 2026
61 of 63 checks passed
@earakely-scale
earakely-scale deleted the edgararakelyan/fd-5908-register-installed-aliases branch November 18, 2026 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant