Repository navigation
feat(bundle): register writes an installed env or artifact under its alias, into a shared store - #744
Merged
earakely-scale merged 1 commit intoNov 18, 2026
Conversation
…alias, into a shared store For promotion to put chromium on the hub, registering a task that names `chromium` has to write chromium, its page driver and its base computer under the ids the hub's tasks name them by. Register gave an installed bundle's agent its alias and refused any other installed entity. It now gives an installed env or artifact its alias too, so chromium registers as `chromium`, with `page`, `ubuntu-24.04-browser` and its image. The env store's refusal of an alias's id moves from namespace routing being on to the store being this machine's own, where its runs record deployments under an alias. A shared store such as the hub's may hold `chromium`, whoever writes it, and register checks before writing anything that an installed env goes only into a shared store. `shared_store` moves from register to `store.routing`, where both use it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
earakely-scale
deleted the
edgararakelyan/fd-5908-register-installed-aliases
branch
November 18, 2026 00:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
M8.60 (FD-5908), PR 2 decision 1: chromium reaches the hub through
bundle register.For promotion to put chromium on the hub, registering a task that names
chromiumhas to write chromium and the three entities it needs under the ids the hub's tasks name them by. A plan of that task writes four installed-bundle entities, each with an alias equal to its folder name:@local/agentenv-framework/browsers/chromiumcomputer_appchromium@local/agentenv-framework/drivers/pagecomputer_driverpage@local/agentenv-framework/computers/ubuntu-24.04-browsercomputerubuntu-24.04-browser…/ubuntu-24.04-browser__forms_container_imageubuntu-24.04-browser__forms_container_image, as publishedRegister gave an installed bundle's agent its alias, and refused any other installed entity ("only an agent with an alias is registered from one").
What changes
bundle/register.py:env/store.py:put_documentrefuses a new env under an installed alias's id only in this machine's own store, where its runs record deployments under an alias, and no longer only when namespace routing is on (feat(env): the env store refuses an alias's id only where aliases resolve, so a service may hold one #733). A shared store such as the hub's may holdchromium, whoever writes it: a service, or a registration with routing on.store/routing.py:shared_storemoves here from register, next toconfigured_store, and now looks through a routing store to its configured side. Register and the env store both use it.AGENTS.md: the store rule andbundle register's ids.The store's env of an id still wins over the alias wherever that store is read, and the one-time catch is documented as before: alias deployments recorded in that store before chromium was written.
PR 2 (scaleapi) then registers chromium into the hub during promotion, gated in place as agents are (decision 2).
How it was tested
tst/unit/bundle/register_test.py:chromiuminto a shared store writeschromium,page,ubuntu-24.04-browserand its image under those ids, plus the task. The task's step pinschromiumv1, and the stored chromium namesubuntu-24.04-browserandpage.tst/unit/env/alias_get_test.py:tst/unit/env,store,bundle,a2a_agent,cli,plugins_test.py: 5922 passed. The one failure is the Windows disk recipe's exit code, which fails on main on macOS too.🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
Allows installed envs and artifacts pulled into a registration to use their first alias as their registry ID.
Acknowledgment: earakely-scale explicitly states that stored envs shadow installed aliases, including the effect on deployments recorded before registration. This behavior was not reported as a defect.
Diagram
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Plan selected bundle entries] --> B[Give installed entries their alias IDs] B --> C{Target store} C -->|Local, with installed envs| D[Refuse before writing] C -->|Shared| E[Rewrite references and derived IDs] E --> F[Write versions through the target ledger]Reviews (1) · Last reviewed commit: "feat(bundle): register writes an install..." · Reviewed by Greptile