Repository navigation
fix(computers): a composed computer's key doesn't change with the id its driver is stored under - #738
Merged
earakely-scale merged 1 commit intoNov 18, 2026
Conversation
…its driver is stored under The composer installed a computer's driver in a folder named for the driver's id's last part, and named its programs and their file after it. A driver stored under a registry prefix (a bundle registered with --prefix) has no "/" in its id, so the whole prefixed id named the folder, went into the composed image's Dockerfile, and changed its key. The same computer registered under two prefixes then shared no compose: each registration composed every computer again, the desktop and each app's one-app computer. The folder is now named for the name the driver's class declares (@computer_driver(name=...)), as an app's is for its environment name. Every shipped driver declares the name of its folder, so a computer composed of one keeps its key. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
earakely-scale
marked this pull request as ready for review
November 17, 2026 23:43
earakely-scale
deleted the
edgararakelyan/driver-folder-by-declared-name
branch
November 18, 2026 00:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A composed computer's key no longer depends on the id its driver is stored under. So the same computer registered
under two prefixes shares its composes instead of composing everything again.
The composer installed the driver in
/opt/agentenv/drivers/<name>, and named its programs and their file after it,with
<name>the last/part of the driver's id. Two cases:@local/agentenv-framework/drivers/reference, that'sreference.psi-tc-shelfway-cracked-lamp-refund-full-desktop-reference, theid has no
/. The whole prefixed id named the folder, went into the composed Dockerfile, and changed the key.The folder is now named for the name the driver's class declares,
@computer_driver(name=...), read at put into itsdeclaration.name(gate.driver_folder). That's the same way an app's folder is named for its environment name(
gate.app_folder). It's used for the container form, the Windows and Omarchy disks, and the macOS VM bundle.No key changes for the shipped drivers. Every one declares the name of its folder:
reference,cua-driverandpage;agent-desktop,macos-harness,codex-computer-useandaside.So a computer composed of one keeps its key. A driver stored under any other id gets its declared name once, and a
computer composed of it composes once more.
Why
A PSI sweep in synthetic-pipelines registers each task's whole-computer desktop under the task's own prefix,
psi-tc-<spec>-full-desktop-. Each registration composed the desktop and every app's one-app computer again, about30 min and 80 GB each. Two of fifteen registrations filled a 242 GB builder.
Two specs' staged bundles were byte-identical, yet their keys differed. Their composed images differed in one thing,
the driver's folder:
/opt/agentenv/drivers/psi-tc-shelfway-cracked-lamp-refund-full-desktop-referencein one;/opt/agentenv/drivers/psi-tc-curbfinch-furnish-day-full-desktop-referencein the other.The same would happen to any computer registered more than once under different prefixes, on a hub as well.
Proof
reuses the first one's images, with the same keys.
test_disk_recipe.py::test_a_windows_install_boots_its_iso_first_pressing_enter_and_finds_its_answers_on_a_removable_drive.It fails on
maintoo on this Mac, because it runs the recipe's shell with macOS's tools.ruff check src tstpasses.mainhaschanged the base computer since that release, so only the release has a published base. On it I registered 14 PSI
whole-computer desktops, each under its own prefix (
psi-tc-<spec>-full-desktop-)."reusing the image of the same key" lines and no "building the image" lines. Each took about 7.5 min, mostly
probing the reused images.
242 GB builder.
🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge.Summary
Driver folders and service names now come from the driver’s declared name, so storing the same driver under different IDs no longer changes its image key.
Reviews (1) · Last reviewed commit: "fix(computers): a composed computer's ke..." · Reviewed by Greptile