Skip to content

test(computer): an app's readiness check is compared with its seconds waited masked - #721

Merged
earakely-scale merged 1 commit into
mainfrom
edgararakelyan/app-ready-seconds-masked
Nov 16, 2026
Merged

earakely-scale merged 1 commit into
mainfrom
edgararakelyan/app-ready-seconds-masked

Conversation

@earakely-scale

@earakely-scale earakely-scale commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Why

packages/agentenv-protocol/tests/test_computer_app_server.py::test_the_driver_asks_each_apps_server_on_the_socket_in_its_folder failed on #720's CodeBuild run (Linux, xdist, about 14k tests on one machine):

At index 2 diff: ReadyCheck(name='app mail', ok=False, detail="not ready yet, 1 s in: ...") != ReadyCheck(name='app mail', ok=False, detail="not ready yet, 0 s in: ...")

A readiness detail says how long the app has waited: the real seconds since its server started, or since its app launched, rounded to a whole second (app_runtime.py, waited_s). The test expected 0 s in, so it passed only when the check came within half a second of the server starting. A busy runner takes longer.

What changes

The two assertions on that detail compare it with the seconds masked (N s in). Everything else in the detail is still checked: which app, what it's waiting for, and the ready check that returned False. The 30 s timeout branch is still checked by the test's late assertion. Test-only.

Testing

Locally, with the mail app's start pushed back 0.6 s to stand in for a busy runner: on main the test fails, and with this change it passes. Without the delay it passes too.

🤖 Generated with Claude Code

RetriggerView in GreptileConfidence Score: 5/5

This test-only change appears safe to merge.

Summary

The PR removes a timing-sensitive expectation from two readiness assertions.

  • The app-server test compares readiness details without fixing elapsed seconds.

No actionable issues found. Tests were not run during this review.

Reviews (1) · Last reviewed commit: "test(computer): an app's readiness check..." · Reviewed by Greptile

… waited masked

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@earakely-scale
earakely-scale requested a review from a team as a code owner November 16, 2026 20:37
@earakely-scale
earakely-scale merged commit 6e3bc40 into main Nov 16, 2026
36 checks passed
@earakely-scale
earakely-scale deleted the edgararakelyan/app-ready-seconds-masked branch November 16, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant