Repository navigation
test(computer): an app's readiness check is compared with its seconds waited masked - #721
Merged
Merged
Conversation
… waited masked Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
packages/agentenv-protocol/tests/test_computer_app_server.py::test_the_driver_asks_each_apps_server_on_the_socket_in_its_folderfailed on #720's CodeBuild run (Linux, xdist, about 14k tests on one machine):A readiness detail says how long the app has waited: the real seconds since its server started, or since its app launched, rounded to a whole second (
app_runtime.py,waited_s). The test expected0 s in, so it passed only when the check came within half a second of the server starting. A busy runner takes longer.What changes
The two assertions on that detail compare it with the seconds masked (
N s in). Everything else in the detail is still checked: which app, what it's waiting for, and the ready check that returned False. The 30 s timeout branch is still checked by the test'slateassertion. Test-only.Testing
Locally, with the mail app's start pushed back 0.6 s to stand in for a busy runner: on
mainthe test fails, and with this change it passes. Without the delay it passes too.🤖 Generated with Claude Code


Confidence Score: 5/5
This test-only change appears safe to merge.Summary
The PR removes a timing-sensitive expectation from two readiness assertions.
No actionable issues found. Tests were not run during this review.
Reviews (1) · Last reviewed commit: "test(computer): an app's readiness check..." · Reviewed by Greptile