Skip to content

fix(release): try chromium's first index push again while GHCR links its new package - #717

Merged
earakely-scale merged 1 commit into
mainfrom
edgararakelyan/fd-5908-retry-first-index-push
Nov 16, 2026
Merged

earakely-scale merged 1 commit into
mainfrom
edgararakelyan/fd-5908-retry-first-index-push

Conversation

@earakely-scale

@earakely-scale earakely-scale commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

What and why

M8.60 (FD-5908): v0.9.1545 composed chromium on both arches but shipped without it, because its first push to GHCR was half refused.

computer-publish joins the two arches' images into one index with docker buildx imagetools create, which pushes both manifests at once. The first push created ghcr.io/scaleapi/agentenv-chromium. The second was refused with 403 Forbidden ... denied: permission_denied: write_package, because GHCR links a new package to the repository only after its first push.

infra_build.py's retry already waits that refusal out (_NOT_YET_LINKED), but only for docker push, so nothing tried again and the job failed. The release then shipped without chromium, as designed, with a warning.

What changes

  • infra_build.py: the retry treats docker buildx imagetools create as a push, so a write_package refusal of either is tried again after 30, 60 and 120 s. Other commands that GHCR refuses still fail at once.
  • A test with v0.9.1545's error line. It fails on main's script and passes with the fix.

What v0.9.1545 left

  • The package now exists, is public, and is linked to this repository. An anonymous token reads it, as an install does.
  • It holds one untagged manifest, the arch that got through, and no index. The next release pushes the index and both images. The untagged manifest can stay or be deleted; nothing refers to it.
  • v0.9.1545's wheel has no computers record, so its installs compose chromium as before.

How it was tested

  • tst/unit/test_infra_build_script.py: 77 passed.
  • The release that this PR's bump-version cuts is the real test. Now that the package exists, it should no longer hit the refusal, and the retry covers the next app's first release. I'll watch it.

🤖 Generated with Claude Code

RetriggerView in GreptileConfidence Score: 5/5

This PR appears safe to merge.

Summary

Extends GHCR package-linking retries to docker buildx imagetools create.

  • Computer index pushes retry while GHCR links a new package.

Reviews (1) · Last reviewed commit: "fix(release): try chromium's first index..." · Reviewed by Greptile

…its new package

v0.9.1545's computer-publish created ghcr.io/scaleapi/agentenv-chromium with one arch's manifest and had the
other's refused (permission_denied: write_package), since `imagetools create` pushes both at once and GHCR
links a new package to the repository only after the first push. The retry already waits that out for
`docker push`; it now covers `docker buildx imagetools create` too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@earakely-scale
earakely-scale requested a review from a team as a code owner November 16, 2026 19:47
@earakely-scale
earakely-scale merged commit 49fb326 into main Nov 16, 2026
61 of 63 checks passed
@earakely-scale
earakely-scale deleted the edgararakelyan/fd-5908-retry-first-index-push branch November 16, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant