Skip to content

fix(release): the composed computers' state folder is the compose step's, since a job's env can't read the runner - #707

Merged
earakely-scale merged 2 commits into
mainfrom
edgararakelyan/fd-5908-release-workflow-runner-context
Nov 16, 2026
Merged

earakely-scale merged 2 commits into
mainfrom
edgararakelyan/fd-5908-release-workflow-runner-context

Conversation

@earakely-scale

@earakely-scale earakely-scale commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

What and why

GitHub has refused publish-pypi.yml since #705: the computer-build job's own env named ${{ runner.temp }}, and the runner context is only a step's. So the v0.9.1542 tag started no release run (0 jobs), and every release until this lands is held up.

What changes

  • XDG_STATE_HOME moves from computer-build's job env to the env of its compose step, where runner.temp is allowed.
  • test_release_infra_images.py checks that each workflow's job-level env reads only the contexts a job has (github, inputs, matrix, needs, secrets, strategy, vars). On the old file it fails naming computer-build and runner.

How it was tested

  • actionlint: context "runner" is not allowed here on line 387 before; no errors after.
  • tst/unit/test_release_infra_images.py: 59 passed.

bump-version, so its merge cuts the release 1542's tag couldn't.

🤖 Generated with Claude Code

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge.

Summary

Moves XDG_STATE_HOME to the compose step, where runner.temp is allowed.

  • The release workflow can use its runner-specific state folder during composition.

Reviews (2) · Last reviewed commit: "test(release): every context a job env's..." · Reviewed by Greptile

…p's, since a job's env can't read the runner

GitHub refused publish-pypi.yml since #705, as a job's own env named runner.temp, so v0.9.1542's tag started no
release. The folder is set on the step that composes, and a test checks every workflow's job env reads only what a
job can.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Comment thread tst/unit/test_release_infra_images.py Resolved
… not only its first

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@earakely-scale
earakely-scale merged commit 9821715 into main Nov 16, 2026
35 checks passed
@earakely-scale
earakely-scale deleted the edgararakelyan/fd-5908-release-workflow-runner-context branch November 16, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant