Repository navigation
Send User-Agent header on app storage uploads - #640
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 4 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
The multipart upload request in StorageEndpoint was built without the User-Agent header that all other requests send. Add it, plus a unit test that checks the header on a regular request and on an upload. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
diemol
force-pushed
the
fix/user-agent-multipart-upload
branch
from
October 20, 2026 10:26
c68e895 to
29516a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
StorageEndpoint.postMultipartResponsebuilds its own request and did not set theUser-Agentheader. All other requests get it fromAbstractEndpoint.createRequest. This PR adds the header to the upload request too.Motivation and Context
Every HTTP request should send
User-Agent: SauceREST/<version>. File uploads to app storage were the only ones missing it.How Has This Been Tested?
Added
UserAgentTest. It uses an OkHttp interceptor to capture the outgoing request and checks theUser-Agentheader for a regular request (getFiles) and for an upload (uploadFile). The upload test fails without the fix and passes with it.Types of changes
Screenshots (if appropriate):
Checklist
Further comments
Locally, 14 existing unit tests fail only because Sauce credentials are not set (
MissingCredentials). They are not related to this change.🤖 Generated with Claude Code