Skip to content

Use yauzl directly instead of extract-zip - #458

Merged
nex3 merged 2 commits into
sass:mainfrom
sass-contrib:unzip
Nov 7, 2026
Merged

nex3 merged 2 commits into
sass:mainfrom
sass-contrib:unzip

Conversation

@ntkme

@ntkme ntkme commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Honestly this might not the best solution given node's native zlib.ZipFile is still considered "experimental".

However, given that all npm packages I found for unzipping are either not well established or not well maintained, an experimental native solution might still be better.

@nex3

nex3 commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

I'm landing #459 in the short term because I want to get a release we know will work out there, but I do think moving off of extract-zip is the way to go, since it seems unmaintained.

I'd feel more comfortable using Node.js's built-in support if it were at least covered by all the Node versions we support. Would it be feasible to use yauzl directly instead?

(Also note that this should now include a reversion of #459)

@ntkme ntkme changed the title Use node's native zlib.ZipFile if available Use yauzl directly instead of extract-zip Nov 7, 2026
@ntkme

ntkme commented Nov 7, 2026

Copy link
Copy Markdown
Contributor Author

@nex3 Replaced with yauzl. Local test worked on both node 24/26.

@nex3 nex3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nex3
nex3 merged commit edb02c7 into sass:main Nov 7, 2026
18 checks passed
@ntkme
ntkme deleted the unzip branch November 7, 2026 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1.108.0 win32-x64 binary does not run on windows

2 participants