Repository navigation
Use yauzl directly instead of extract-zip - #458
Merged
Merged
Conversation
Contributor
|
I'm landing #459 in the short term because I want to get a release we know will work out there, but I do think moving off of extract-zip is the way to go, since it seems unmaintained. I'd feel more comfortable using Node.js's built-in support if it were at least covered by all the Node versions we support. Would it be feasible to use yauzl directly instead? (Also note that this should now include a reversion of #459) |
Contributor
Author
|
@nex3 Replaced with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Honestly this might not the best solution given node's native
zlib.ZipFileis still considered "experimental".However, given that all npm packages I found for unzipping are either not well established or not well maintained, an experimental native solution might still be better.