test(smoke): match fingerprinted featured-topics carousel markup (#1604) - #1616
Merged
Merged
Conversation
The featured-topics homepage-mount smoke test keyed on id="featured-topics-carousel" (the real SSR attribute is data-app=) OR the bare unhashed /js/x.js literal. #1604 content-hashes the island bundle (/js/featured-topics-carousel-<hash>.js), so both markers stopped matching and the smoke gate failed on every deploy once the manifest pipeline was fixed (PR #1613) — even though the carousel renders correctly (SSR section + hashed script both present, verified live on DEV). - mount check now matches data-app="featured-topics-carousel" (+ hash-tolerant script fallback) - bundle-200 check resolves the real hashed URL from the homepage HTML instead of assuming the unhashed path Verified: 7/7 pass against live DEV.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Follow-up to #1613. Once the island-manifest pipeline was fixed,
test/smoke/featured-topics.smoke.test.jsbegan failing on every deploy — not a regression: the carousel renders correctly, the test just checks stale markers.id="featured-topics-carousel", but the island's real SSR attribute isdata-app="featured-topics-carousel"(seehugo-apps/src/featured-topics-carousel/main.ts→querySelectorAll('[data-app="featured-topics-carousel"]'))./js/featured-topics-carousel.jspath, but Content-hash the Vite JS island bundles (stale-edge risk on ~50 /js/*.js) #1604 content-hashes it to/js/featured-topics-carousel-<hash>.js.Fix
data-app="featured-topics-carousel"with a hash-tolerant script-tag fallback.Verification
Ran against live DEV (SMOKE_BASE_URL/SMOKE_SRV_URL): 7/7 pass. Confirmed the live homepage serves the fingerprinted
/js/featured-topics-carousel-D2NOJUxn.jsand the SSR<section data-app=featured-topics-carousel>mount.