test(concepts): remove 9 orphaned fetch-concepts unit tests (#1327) - #1570
Merged
Conversation
Commit 779a305 (#1567, retire legacy Hugo concept path) deleted scripts/fetch-concepts.ts but left its 9 test files behind. They import yamlEscape/frontmatter/ConceptPayload from the now-deleted module, so vitest fails at collection with "Cannot find module ../../../scripts/fetch-concepts.ts" — 9 failed suites on main. The tested functions emitted Hugo concept-page frontmatter, which is permanently retired (rollback = code revert, not a flag), so there is no live module to repoint to. Delete the dead tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI unit tests are failing on
main(run 31327698582): 9 failed suites, 974 passed.All 9 failures are collection-time errors, not assertions:
Root cause
Commit
779a305d(#1567 — retire legacy Hugo concept path + LEGACY_CONCEPT_RENDER) deleted the 455-linescripts/fetch-concepts.ts, but left its 9 test files behind:fetch-concepts.test.tsfetch-concepts-{api-docs,blog-posts,community-events,crosslinks,help-docs,missions,samples,videos}.test.tsEach imports only
yamlEscape/frontmatter/ConceptPayloadfrom the deleted module. Those functions emitted Hugo concept-page frontmatter — a path that is now permanently retired (rollback is a code revert, not a flag), so there is no live module to repoint the imports to.Fix
Delete the 9 orphaned test files. No production code changed. The only non-test reference to
fetch-conceptsin live code (scripts/publish-content.ts:932) is a comment.Verification
npx vitest run --project unit test/unit/scripts/→ 13 files, 106 tests passed (was 9 failed suites before the change).