ci(alerts): auth remaining npm-ci workflows to private GitHub Packages - #1462
Merged
Conversation
The deploy + scheduled/dispatch workflows all root-npm-ci the alerts dep (@sap-tutorials/cds-alert-notification) and would 401 on next run. Add packages:read + NODE_AUTH_TOKEN (built-in GITHUB_TOKEN, PACKAGES_READ_TOKEN fallback) to every ROOT install site: - deploy.yml: 4 jobs (deploy prefetch, smoke-test, e2e, a11y-scan) - docs-deploy, mcp-ux-weekly, content-drift-check, rebuild-content, rebuild-content-qa Only root installs touched; --prefix subdir installs and existing App-token steps (tutorial-fetch) left intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the ANS integration (#1457). Six workflows still root-
npm cithe private@sap-tutorials/cds-alert-notificationdep without registry auth — they'd hit401 Unauthorizedthe next time they run (deploy, docs publish, nightlies, content rebuilds). This adds the samepackages: read+NODE_AUTH_TOKEN(built-inGITHUB_TOKEN,PACKAGES_READ_TOKENfallback) pattern already proven on the PR-gating checks.Scope — root installs only:
deploy.yml— 4 jobs (deploy prefetch @194, smoke-test, e2e, a11y-scan)docs-deploy.yml,mcp-ux-weekly.yml,content-drift-check.yml,rebuild-content.yml,rebuild-content-qa.ymlDeliberately untouched:
npm --prefix hugo-apps/app/*subdir installs (don't pull the root dep) and the existingcreate-github-app-tokensteps in content-drift/rebuild (used for tutorial-fetch — preserved).mcp-ux-weeklygained a jobpermissionsblock (it had none).All 6 YAML-validated. Completes the CI-auth coverage so no workflow 401s on the alerts dep.
🤖 Generated with Claude Code