fix(ci): add GitHub Packages auth to docs-deploy workflow - #1461
Merged
Conversation
PR #1457 added the private GitHub Packages dependency @sap-tutorials/cds-alert-notification (+ .npmrc reading ${NODE_AUTH_TOKEN}) and updated 8 workflows with 'packages: read' + NODE_AUTH_TOKEN, but missed docs-deploy.yml. Its 'npm ci' now fails with E401 Unauthorized against npm.pkg.github.com. Mirror the sibling-workflow pattern: grant 'packages: read' and set NODE_AUTH_TOKEN on the npm ci step.
jung-thomas
marked this pull request as ready for review
August 3, 2026 21:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Deploy Docs to GitHub Pages workflow began failing on the merge of #1457 (run):
Root cause
PR #1457 (ANS integration) added the private GitHub Packages dependency
@sap-tutorials/cds-alert-notificationand a.npmrcthat points@sap-tutorialsatnpm.pkg.github.comwith_authToken=${NODE_AUTH_TOKEN}. It updated 8 workflows (unit-tests, schema-drift-check, api-docs-drift, cds-build-staging-check, e2e-coverage-nudge, regen-alerts-lockfile, srv-qa-cp-list-check, validate-api-docs-yaml) withpackages: read+NODE_AUTH_TOKENon their install steps — but misseddocs-deploy.yml, whosenpm cinow can't authenticate.Fix
Mirror the sibling-workflow pattern in
docs-deploy.yml:packages: readto the jobpermissionsNODE_AUTH_TOKEN: ${{ secrets.PACKAGES_READ_TOKEN || secrets.GITHUB_TOKEN }}on thenpm cistepNo other change.